From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3B33C433E0 for ; Wed, 3 Mar 2021 00:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1DC264FB4 for ; Wed, 3 Mar 2021 00:45:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238459AbhCCA1p (ORCPT ); Tue, 2 Mar 2021 19:27:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:49020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350710AbhCBMXv (ORCPT ); Tue, 2 Mar 2021 07:23:51 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 73C2264FAC; Tue, 2 Mar 2021 11:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614686345; bh=lEwrTZXHcHuVgaYaPFEZS0IRXnTb0SnWfeJMNLLVkrY=; h=From:To:Cc:Subject:Date:From; b=cHGQDgDy1AHqW89bI9X6QD/ZdQND+RxmnSSiEdjA04mpROZ7yHNVdW98NObtcQjzY y0gbl+S0FTXXzzQfM3qCj7Jj7WG/3/kmMgGOHbRJUT8aTGq7Cg/w+PhQOs5QzabPXE CiTrG3HrbYM5tw8yEVNze6CfDSboQgf+yKxP73gaPHf3ZefzqfACuk9y3BlzBcEn/2 WYQpAtB8gowJTf05XJ97qqGh7Ksx0R3X6RObNttZfuvda+fZmHngAXH+8QE88gR/4I LrdALQbx/J7Chv04/Di3Di5xTyPsJ6SQ16ZLTE9tfJWpKSuzaqu10lhKZcRIZwjVBn yY4RvrDMTRFdg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Steven J. Magnani" , Jan Kara , Sasha Levin Subject: [PATCH AUTOSEL 4.14 01/13] udf: fix silent AED tagLocation corruption Date: Tue, 2 Mar 2021 06:58:51 -0500 Message-Id: <20210302115903.63458-1-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: "Steven J. Magnani" [ Upstream commit 63c9e47a1642fc817654a1bc18a6ec4bbcc0f056 ] When extending a file, udf_do_extend_file() may enter following empty indirect extent. At the end of udf_do_extend_file() we revert prev_epos to point to the last written extent. However if we end up not adding any further extent in udf_do_extend_file(), the reverting points prev_epos into the header area of the AED and following updates of the extents (in udf_update_extents()) will corrupt the header. Make sure that we do not follow indirect extent if we are not going to add any more extents so that returning back to the last written extent works correctly. Link: https://lore.kernel.org/r/20210107234116.6190-2-magnani@ieee.org Signed-off-by: Steven J. Magnani Signed-off-by: Jan Kara Signed-off-by: Sasha Levin --- fs/udf/inode.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index dd57bd446340..e0e2bc19c929 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -540,11 +540,14 @@ static int udf_do_extend_file(struct inode *inode, udf_write_aext(inode, last_pos, &last_ext->extLocation, last_ext->extLength, 1); + /* - * We've rewritten the last extent but there may be empty - * indirect extent after it - enter it. + * We've rewritten the last extent. If we are going to add + * more extents, we may need to enter possible following + * empty indirect extent. */ - udf_next_aext(inode, last_pos, &tmploc, &tmplen, 0); + if (new_block_bytes || prealloc_len) + udf_next_aext(inode, last_pos, &tmploc, &tmplen, 0); } /* Managed to do everything necessary? */ -- 2.30.1