From: "Marek Behún" <kabel@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file
Date: Fri, 12 Mar 2021 17:32:24 +0100 [thread overview]
Message-ID: <20210312173224.1e3d6082@kernel.org> (raw)
In-Reply-To: <20210312161857.ytknen5d5zhfhtbk@pali>
On Fri, 12 Mar 2021 17:18:57 +0100
Pali Rohár <pali@kernel.org> wrote:
> On Friday 12 March 2021 16:53:32 Andrew Lunn wrote:
> > > So theoretically the turris-mox-rwtm driver can be renamed into
> > > something else and we can add a different compatible in order not to
> > > sound so turris-mox specific.
> >
> > That would be a good idea. And if possible, try to push the hardware
> > random number code upstream in the firmware repos, so everybody gets
> > it by default, not just those using your build. Who is responsible for
> > upstream? Marvell?
>
> Hello Andrew! The issue is that upstream Marvell repository contains
> only 'fuse.bin' application which is suitable only for fuse programming.
> I think it is not correct if this Marvell fuse application start
> providing other functionality not relevant to fuse programming.
Why not? We can rename it to fuse+hwrng and implement hwrng there.
Maybe Konstantin will agree with such a change :)
> And Marvell does not provide any other application (publicly). So it would
> be needed to send it as another application, not part of 'fuse.bin'. And
> then it complicates build system and compile options, which is already
> too complicated (you need to set tons of TF-A options and prepare two
> sets of cross compile toolchains).
>
> But because application / firmware for MOX / Armada 3720 is actively
> developed on different place, I do not think that it make sense to send
> every change to two different locations (and wait for Marvell until
> review every change and include it into their repository). Such thing
> just increase maintenance cost at both sides.
This is a little bit better argument than the previous one. But I
think Andrew may be right in that for end-users it just complicates
things if they have more options. Better to give them one option.
> For me it looks like a better solution to provide 'wtmi_app.bin'
> application with HW number generator from separate repository, where it
> is currently developed and where it is available for a longer time.
>
> We are planning to send documentation update to Trusted-Firmware project
> to specify how to build Armada 3720 firmware image with our application.
> So people who are building Armada 3720 firmware would be able to switch
> from Marvell's 'fuse.bin' application to our 'wtmi_app.bin'.
next prev parent reply other threads:[~2021-03-12 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210308153703.23097-1-kabel@kernel.org>
2021-03-08 15:37 ` [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Marek Behún
2021-03-12 8:58 ` Gregory CLEMENT
2021-03-12 9:10 ` Marek Behún
2021-03-12 14:48 ` Andrew Lunn
2021-03-12 15:17 ` Marek Behún
2021-03-12 15:53 ` Andrew Lunn
2021-03-12 16:18 ` Pali Rohár
2021-03-12 16:32 ` Marek Behún [this message]
2021-03-15 10:14 ` Pali Rohár
2021-03-15 12:08 ` Andrew Lunn
2021-04-26 18:36 ` Pali Rohár
2021-04-26 19:52 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312173224.1e3d6082@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pali@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).