From: Atul Gopinathan <atulgopinathan@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8192e: Fix incorrect source in memcpy()
Date: Tue, 23 Mar 2021 22:59:07 +0530 [thread overview]
Message-ID: <20210323172907.GB21444@atulu-nitro> (raw)
In-Reply-To: <20210323135811.GI1717@kadam>
On Tue, Mar 23, 2021 at 04:58:11PM +0300, Dan Carpenter wrote:
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> This is very clever detective work. How did you spot the bug?
I remember trying to investigate a sparse warning couple of weeks ago in
the same file and went through the code when my eyes caught a struct
pointer being indexed, which looked wierd. On further reading of the
code and trying to make sense of what was happening (especially after
calculating the size of the pointer) I became sure that it wasn't
correct.
The first patch led me to the second patch as they were related,
"CcxRmState" was used in the same memcpy() of the first patch. I caught
the error in it's type while trying to fix the first.
Thank you for your encouraging words :D
Regards,
Atul
prev parent reply other threads:[~2021-03-23 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 11:34 [PATCH v2 1/2] staging: rtl8192e: Fix incorrect source in memcpy() Atul Gopinathan
2021-03-23 11:34 ` [PATCH v2 2/2] staging: rtl8192e: Change state information from u16 to u8 Atul Gopinathan
2021-03-23 14:08 ` Dan Carpenter
2021-03-23 13:58 ` [PATCH v2 1/2] staging: rtl8192e: Fix incorrect source in memcpy() Dan Carpenter
2021-03-23 17:29 ` Atul Gopinathan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323172907.GB21444@atulu-nitro \
--to=atulgopinathan@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox