From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Wan, Kaike" <kaike.wan@intel.com>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH for-rc 1/4] IB/hfi1: Call xa_destroy before freeing dummy_netdev
Date: Thu, 1 Apr 2021 10:48:14 -0300 [thread overview]
Message-ID: <20210401134814.GG2710221@ziepe.ca> (raw)
In-Reply-To: <DM6PR11MB330637BAEB1AA8D7FDC56225F47B9@DM6PR11MB3306.namprd11.prod.outlook.com>
On Thu, Apr 01, 2021 at 01:42:57PM +0000, Wan, Kaike wrote:
> Shouldn't xa_destroy() always be called during cleanup, just in case
> that something is left behind?
No.
> Check the following:
Since I didn't write a WARN_ON(!xa_empty()) it means they were not
made empty.
IIRC there is some special stuff there with XA_ZERO_ENTRY that causes
it.
Jason
next prev parent reply other threads:[~2021-04-01 18:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1617025700-31865-1-git-send-email-dennis.dalessandro@cornelisnetworks.com>
2021-03-29 13:48 ` [PATCH for-rc 1/4] IB/hfi1: Call xa_destroy before freeing dummy_netdev dennis.dalessandro
2021-03-29 14:09 ` Jason Gunthorpe
2021-03-31 19:36 ` Dennis Dalessandro
2021-04-01 6:06 ` Greg KH
2021-04-01 14:02 ` Dennis Dalessandro
2021-04-01 14:12 ` Greg KH
2021-04-01 15:00 ` Dennis Dalessandro
2021-04-01 12:33 ` Jason Gunthorpe
2021-04-01 13:42 ` Wan, Kaike
2021-04-01 13:48 ` Jason Gunthorpe [this message]
2021-03-29 13:48 ` [PATCH for-rc 2/4] IB/hfi1: Call xa_destroy before unloading the module dennis.dalessandro
2021-03-29 14:11 ` Jason Gunthorpe
2021-04-08 13:30 ` Dennis Dalessandro
2021-03-29 13:48 ` [PATCH for-rc 3/4] IB/hfi1: Fix probe time panic when AIP is enabled with a buggy BIOS dennis.dalessandro
2021-04-07 23:04 ` Jason Gunthorpe
2021-03-29 13:48 ` [PATCH for-rc 4/4] IB/hfi1: Fix regressions in security fix dennis.dalessandro
2021-03-29 18:36 ` Ira Weiny
2021-04-07 18:33 ` Jason Gunthorpe
2021-04-07 20:20 ` Dennis Dalessandro
2021-04-13 22:55 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401134814.GG2710221@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=kaike.wan@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox