From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBD0DC433B4 for ; Thu, 15 Apr 2021 16:57:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1F5D611AC for ; Thu, 15 Apr 2021 16:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233343AbhDOQ6Q (ORCPT ); Thu, 15 Apr 2021 12:58:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:48086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231549AbhDOQ6P (ORCPT ); Thu, 15 Apr 2021 12:58:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2EB1B60231; Thu, 15 Apr 2021 16:57:51 +0000 (UTC) Date: Thu, 15 Apr 2021 17:57:48 +0100 From: Catalin Marinas To: Sami Tolvanen Cc: Nathan Chancellor , Will Deacon , Nick Desaulniers , Jian Cai , linux-arm-kernel , LKML , clang-built-linux , "# 3.4.x" Subject: Re: [PATCH] arm64: alternatives: Move length validation in alternative_{insn,endif} Message-ID: <20210415165748.GG1015@arm.com> References: <20210414000803.662534-1-nathan@kernel.org> <20210415091743.GB1015@arm.com> <20210415140224.GE1015@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Apr 15, 2021 at 08:50:25AM -0700, Sami Tolvanen wrote: > On Thu, Apr 15, 2021 at 7:02 AM Catalin Marinas wrote: > > > > On Thu, Apr 15, 2021 at 06:25:57AM -0700, Nathan Chancellor wrote: > > > On Thu, Apr 15, 2021 at 10:17:43AM +0100, Catalin Marinas wrote: > > > > On Tue, Apr 13, 2021 at 05:08:04PM -0700, Nathan Chancellor wrote: > > > > > After commit 2decad92f473 ("arm64: mte: Ensure TIF_MTE_ASYNC_FAULT is > > > > > set atomically"), LLVM's integrated assembler fails to build entry.S: > > > > > > > > > > :5:7: error: expected assembly-time absolute expression > > > > > .org . - (664b-663b) + (662b-661b) > > > > > ^ > > > > > :6:7: error: expected assembly-time absolute expression > > > > > .org . - (662b-661b) + (664b-663b) > > > > > ^ > > > > > > > > I tried the latest Linus' tree and linux-next (defconfig) with this > > > > commit in and I can't get your build error. I used both clang-10 from > > > > Debian stable and clang-11 from Debian sid. So, which clang version did > > > > you use or which kernel config options? > > > > > > Interesting, this reproduces for me with LLVM 12 or newer with just > > > defconfig. > > > > It fails for me as well with clang-12. Do you happen to know why it > > works fine with previous clang versions? > > It looks like CONFIG_ARM64_AS_HAS_MTE is not set when we use the > integrated assembler with LLVM 11, and the code that breaks later > versions is gated behind CONFIG_ARM64_MTE. That explains it, thanks. -- Catalin