From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 266B0C43616 for ; Mon, 3 May 2021 16:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14459611AD for ; Mon, 3 May 2021 16:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234682AbhECQ6j (ORCPT ); Mon, 3 May 2021 12:58:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:45566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233619AbhECQ43 (ORCPT ); Mon, 3 May 2021 12:56:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C2BC86140E; Mon, 3 May 2021 16:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620060224; bh=o2t2W2YyIFJIlQucS6TNKdg6QFtpsMeIboeh/CYstVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WgBrIn22PlZCpT6AIqDEHj8lKzhSdTjy1aHgWt4K6G5vfIpbJJbEF0ojy3Yy24JGk vBXi/LmLoIh5SC3qyeo9y44p4Z0aZ5UlrPnXbVIBZh+fL+wAx1FqTUNkn8Ku2w5Wem t8hmUY0pcHhJUcU1kwRrrg1GBMLNEfcReXXj4cn7KXsMRkcxYHXVWCoP4avFudfFcG mOkkt2PYOoxaRQbXJFRaKFR8WpdEMma1018zmhraiW7mOynkqV8SkW+ANxYuVUN/Tg cblru5ZLtGmn/VElr90xdu5HNsaOVmP94F/3xWM655nT3xmpHawwHXAUfr0gt/9pAp +Q86w2CbXXK1g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Yingliang , Hulk Robot , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 10/16] media: i2c: adv7511-v4l2: fix possible use-after-free in adv7511_remove() Date: Mon, 3 May 2021 12:43:23 -0400 Message-Id: <20210503164329.2854739-10-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210503164329.2854739-1-sashal@kernel.org> References: <20210503164329.2854739-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yang Yingliang [ Upstream commit 2c9541720c66899adf6f3600984cf3ef151295ad ] This driver's remove path calls cancel_delayed_work(). However, that function does not wait until the work function finishes. This means that the callback function may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling cancel_delayed_work_sync(), which ensures that the work is properly cancelled, no longer running, and unable to re-schedule itself. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/adv7511-v4l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7511-v4l2.c b/drivers/media/i2c/adv7511-v4l2.c index b35400e4e9af..e85777dfe81d 100644 --- a/drivers/media/i2c/adv7511-v4l2.c +++ b/drivers/media/i2c/adv7511-v4l2.c @@ -1570,7 +1570,7 @@ static int adv7511_remove(struct i2c_client *client) client->addr << 1, client->adapter->name); adv7511_init_setup(sd); - cancel_delayed_work(&state->edid_handler); + cancel_delayed_work_sync(&state->edid_handler); i2c_unregister_device(state->i2c_edid); i2c_unregister_device(state->i2c_pktmem); destroy_workqueue(state->work_queue); -- 2.30.2