From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31938C2B9F4 for ; Fri, 25 Jun 2021 13:03:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14CB861926 for ; Fri, 25 Jun 2021 13:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230270AbhFYNGM (ORCPT ); Fri, 25 Jun 2021 09:06:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230151AbhFYNGM (ORCPT ); Fri, 25 Jun 2021 09:06:12 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 930E7C061766 for ; Fri, 25 Jun 2021 06:03:51 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id u190so7529633pgd.8 for ; Fri, 25 Jun 2021 06:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Rtsnu8VD33EKMaZf3cpQ8efCBZxp+xhAKR5JoGpX5Eo=; b=QyicnVxC5A1fEGp5XtFu3wD2OgDufaG+KE0JJ9KpzGa7lNZMm/POMik2AXOxX1zkTG 3J1IUFt9eeLSs/W1TxbtnzkxWiHFHRoseNrxBhaRZHMOz6MBCT6fQt7ROrqIOUqttUZw QU8itF6xaMwH0rMf7sAxh58f2tTPEKeert6XLTeTlx+kPxk4jBP6NSAlQUCkl/f4Rl/o tvN7rnm43Rwy6RxxZbZnRGq2tHOSGNX4NtjwUxcvJixa4Efap/fpKanlZ1kQGKEU1pLX z1blAIpYshe2WZpwUDCgSw2TaFR3hgGkF+y0iIHjiodOYRZzn+PQyEuiGu3LF/YpNVya xC6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Rtsnu8VD33EKMaZf3cpQ8efCBZxp+xhAKR5JoGpX5Eo=; b=TAXMojp5ucN9XhZq9caaxvrtCgWEIblh7pwYOb9OPxLokms9iMdWyRlltr8fMupmYw 51roKN7L6gszNofcdc2TK5Sjll8eYiHZk+vBrvODWfrvUkwerBTBvoewLWL/GpweN/+4 6h5G5G9dQakEWptiOuNWAkVwi/vxhgzyTFQ5pOQDOOPPuVJTkR42E1aM/a7jjY4lq9R6 cuOdOlWQRdgqmy3Xp6XJuLvb8ldQLi55zbWtAav95uefPyxE5gUrn34uT90iYjhyAcH0 T+LrDjQk4rM4ID9AKuvYoWgxArdLBVmPGrJihjCs5Pid6JykyXJkK8oDxfhsy5NsQKGl tXeQ== X-Gm-Message-State: AOAM532s8odduC5w6CUXtUkP5xrsgrNLTyS0EeXfPEv5uqCOGVC1i2vd SEl/GUcNbx9EtjVLtZyTjjRy X-Google-Smtp-Source: ABdhPJwUAHDHJd41dGZtRGQ/ranfWCHDBM1qzYWPFiEQHKE+umUBbxrpcg2Kbl/SsPWdegV92WZ1kg== X-Received: by 2002:a63:185b:: with SMTP id 27mr9809644pgy.164.1624626231083; Fri, 25 Jun 2021 06:03:51 -0700 (PDT) Received: from thinkpad ([2409:4072:600b:2a0:ed5d:53e7:c64e:1bac]) by smtp.gmail.com with ESMTPSA id e4sm5903958pfa.29.2021.06.25.06.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 06:03:50 -0700 (PDT) Date: Fri, 25 Jun 2021 18:33:43 +0530 From: Manivannan Sadhasivam To: Greg KH Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org, linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, kvalo@codeaurora.org, ath11k@lists.infradead.org, stable@vger.kernel.org, Jeffrey Hugo Subject: Re: [PATCH 06/10] bus: mhi: core: Set BHI and BHIe pointers to NULL in clean-up Message-ID: <20210625130343.GA13833@thinkpad> References: <20210625123355.11578-1-manivannan.sadhasivam@linaro.org> <20210625123355.11578-7-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jun 25, 2021 at 02:38:58PM +0200, Greg KH wrote: > On Fri, Jun 25, 2021 at 06:03:51PM +0530, Manivannan Sadhasivam wrote: > > From: Bhaumik Bhatt > > > > Set the BHI and BHIe pointers to NULL as part of clean-up. This > > makes sure that stale pointers are not accessed after powering > > MHI down. > > > > Cc: stable@vger.kernel.org > > Why is this needed for stable, but patch 5/10 is not? > Shoot! This one relies on 5/10 and fixes a corner case where the BHI/BHIe pointers might be used after MHI powerdown. But this requires backporting the patches 5-10 cleanly (a series). So I guess the stable tag should be removed for this patch. We will test this series on stable kernels (on how far) and make sure this doesn't break anything. Then we can share the commit IDs to be backported with details? Thanks, Mani > And what commit does this fix? How far back should it go? > > And is this really fixing anything? > > thanks, > > greg k-h