From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, thara.gopinath@linaro.org,
stable@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: aoss: Fix the out of bound usage of cooling_devs
Date: Tue, 29 Jun 2021 09:55:58 +0530 [thread overview]
Message-ID: <20210629042558.GA3580@workstation> (raw)
In-Reply-To: <YNpVMvhEfrz9EqyO@google.com>
On Mon, Jun 28, 2021 at 04:03:14PM -0700, Matthias Kaehlcke wrote:
[...]
>
>
> A few more previous lines of code for context:
>
> int count = QMP_NUM_COOLING_RESOURCES;
>
> qmp->cooling_devs = devm_kcalloc(qmp->dev, count,
> sizeof(*qmp->cooling_devs),
> GFP_KERNEL);
>
> I would suggest to initialize 'count' to 0 from the start and pass
> QMP_NUM_COOLING_RESOURCES to devm_kcalloc() rather than 'count',
> instead of resetting 'count' afterwards.
Yeah, I thought about it but the actual bug in the code is not resetting
the count value to 0. So fixing this way seems a better option.
Thanks,
Mani
next prev parent reply other threads:[~2021-06-29 4:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 17:27 [PATCH] soc: qcom: aoss: Fix the out of bound usage of cooling_devs Manivannan Sadhasivam
2021-06-28 23:03 ` Matthias Kaehlcke
2021-06-29 4:25 ` Manivannan Sadhasivam [this message]
2021-06-29 14:17 ` Matthias Kaehlcke
2021-06-29 15:28 ` Manivannan Sadhasivam
2021-06-29 15:43 ` Bjorn Andersson
2021-06-29 15:54 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629042558.GA3580@workstation \
--to=manivannan.sadhasivam@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=stable@vger.kernel.org \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox