From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joelaf@google.com>
Cc: Paul Burton <paulburton@google.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] tracing: Resize tgid_map to PID_MAX_LIMIT, not PID_MAX_DEFAULT
Date: Wed, 30 Jun 2021 19:11:45 -0400 [thread overview]
Message-ID: <20210630191145.64f526b0@rorschach.local.home> (raw)
In-Reply-To: <CAJWu+ooJzcTFBFPSqWE5oHe2_4Gt_GHXftcXutk5mm-UX_hUUA@mail.gmail.com>
On Wed, 30 Jun 2021 18:34:11 -0400
Joel Fernandes <joelaf@google.com> wrote:
> > Anyway, I'll wait to hear what Joel says on this. If he thinks this is
> > worth 16M of memory when enabled, I may take it.
>
> I am not a huge fan of the 16M, in Android we enable this feature on
> all devices. Low end Android devices traced in the field are sometimes
> 1 GB and the added memory pressure may be unwelcome. Very least, maybe
> make it optional only for folks who increase pid_max?
Yeah, can we just set it to the size of pid_max, at whatever it is set
to?
-- Steve
next prev parent reply other threads:[~2021-06-30 23:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 0:34 [PATCH 1/2] tracing: Simplify & fix saved_tgids logic Paul Burton
2021-06-30 0:34 ` [PATCH 2/2] tracing: Resize tgid_map to PID_MAX_LIMIT, not PID_MAX_DEFAULT Paul Burton
2021-06-30 12:35 ` Steven Rostedt
2021-06-30 21:09 ` Paul Burton
2021-06-30 21:34 ` Steven Rostedt
2021-06-30 22:34 ` Joel Fernandes
2021-06-30 23:11 ` Steven Rostedt [this message]
2021-07-01 13:55 ` Steven Rostedt
2021-07-01 17:24 ` [PATCH v2 1/2] tracing: Simplify & fix saved_tgids logic Paul Burton
2021-07-01 17:24 ` [PATCH v2 2/2] tracing: Resize tgid_map to pid_max, not PID_MAX_DEFAULT Paul Burton
2021-07-01 18:12 ` Steven Rostedt
2021-07-01 18:15 ` Paul Burton
2021-07-01 18:27 ` Steven Rostedt
2021-07-01 18:07 ` [PATCH v2 1/2] tracing: Simplify & fix saved_tgids logic Joel Fernandes
2021-06-30 12:31 ` [PATCH " Steven Rostedt
2021-06-30 16:43 ` Joel Fernandes
2021-06-30 22:29 ` Joel Fernandes
2021-07-01 17:31 ` Paul Burton
2021-07-01 18:05 ` Joel Fernandes
2021-07-01 18:07 ` Steven Rostedt
2021-07-01 18:09 ` Joel Fernandes
2021-07-01 18:12 ` Paul Burton
2021-07-01 18:26 ` Steven Rostedt
2021-07-01 19:35 ` Joe Perches
2021-07-01 19:51 ` Steven Rostedt
2021-07-01 21:07 ` Joe Perches
2021-07-01 23:49 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630191145.64f526b0@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulburton@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox