From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 321EEC07E9C for ; Mon, 5 Jul 2021 11:00:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18F086194A for ; Mon, 5 Jul 2021 11:00:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231563AbhGELDR (ORCPT ); Mon, 5 Jul 2021 07:03:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:48232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231519AbhGELDN (ORCPT ); Mon, 5 Jul 2021 07:03:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FAD861452; Mon, 5 Jul 2021 11:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625482836; bh=MscP8az8uXnoEo5miPIgH9DjBqD1pv/RFTVjdm8s7aU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=teurOPx8WIubBV3exb3bdFQdKoNh06VPLVnxbhEZFOM37CbkoNbMFgjq8GnAjA6qF lGZvn52NqyLBA664xUqH+5qBPWDJKcxcco5b9jGEQf++ilT35KIZoQDPzvdwGvdlan cZv033WQv9MQ9hCnKe24+rnEKU6uuXSl3nOEaH82Psh/KSnkm/h0JvRP2Ost1m3x+1 am60aS4xiiH+WW1bEmGulcVZCgedhaCFOV4Bpx1jsUhhMFMZwuMtCG5hVs3n2Fn23P Nps+jxMpb4byjq7HxUdmDNQ/jZt8b9+tW/Ka9cYZA9C/vTWuWQJd8ktJloo9BqjoBS /hewkG4aQmZhg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mark Bloch , Maor Gottlieb , Leon Romanovsky , Jason Gunthorpe , Sudip Mukherjee , Greg Kroah-Hartman Subject: [PATCH 5.4 5/6] RDMA/mlx5: Block FDB rules when not in switchdev mode Date: Mon, 5 Jul 2021 07:00:28 -0400 Message-Id: <20210705110029.1513384-6-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210705110029.1513384-1-sashal@kernel.org> References: <20210705110029.1513384-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.130-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.4.130-rc1 X-KernelTest-Deadline: 2021-07-07T11:00+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Mark Bloch commit edc0b0bccc9c80d9a44d3002dcca94984b25e7cf upstream. Allow creating FDB steering rules only when in switchdev mode. The only software model where a userspace application can manipulate FDB entries is when it manages the eswitch. This is only possible in switchdev mode where we expose a single RDMA device with representors for all the vports that are connected to the eswitch. Fixes: 52438be44112 ("RDMA/mlx5: Allow inserting a steering rule to the FDB") Link: https://lore.kernel.org/r/e928ae7c58d07f104716a2a8d730963d1bd01204.1623052923.git.leonro@nvidia.com Reviewed-by: Maor Gottlieb Signed-off-by: Mark Bloch Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe [sudip: manually backport to old file] Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/mlx5/flow.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/infiniband/hw/mlx5/flow.c b/drivers/infiniband/hw/mlx5/flow.c index b198ff10cde9..fddefb29efd7 100644 --- a/drivers/infiniband/hw/mlx5/flow.c +++ b/drivers/infiniband/hw/mlx5/flow.c @@ -13,6 +13,7 @@ #include #include #include +#include #include "mlx5_ib.h" #define UVERBS_MODULE_NAME mlx5_ib @@ -316,6 +317,13 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_FLOW_MATCHER_CREATE)( if (err) goto end; + if (obj->ns_type == MLX5_FLOW_NAMESPACE_FDB && + mlx5_eswitch_mode(dev->mdev->priv.eswitch) != + MLX5_ESWITCH_OFFLOADS) { + err = -EINVAL; + goto end; + } + uobj->object = obj; obj->mdev = dev->mdev; atomic_set(&obj->usecnt, 0); -- 2.30.2