From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Geoff Levand <geoff@infradead.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Sasha Levin <sashal@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH AUTOSEL 5.12 059/104] powerpc/ps3: Add dma_mask to ps3_dma_region
Date: Fri, 9 Jul 2021 22:21:11 -0400 [thread overview]
Message-ID: <20210710022156.3168825-59-sashal@kernel.org> (raw)
In-Reply-To: <20210710022156.3168825-1-sashal@kernel.org>
From: Geoff Levand <geoff@infradead.org>
[ Upstream commit 9733862e50fdba55e7f1554e4286fcc5302ff28e ]
Commit f959dcd6ddfd29235030e8026471ac1b022ad2b0 (dma-direct: Fix
potential NULL pointer dereference) added a null check on the
dma_mask pointer of the kernel's device structure.
Add a dma_mask variable to the ps3_dma_region structure and set
the device structure's dma_mask pointer to point to this new variable.
Fixes runtime errors like these:
# WARNING: Fixes tag on line 10 doesn't match correct format
# WARNING: Fixes tag on line 10 doesn't match correct format
ps3_system_bus_match:349: dev=8.0(sb_01), drv=8.0(ps3flash): match
WARNING: CPU: 0 PID: 1 at kernel/dma/mapping.c:151 .dma_map_page_attrs+0x34/0x1e0
ps3flash sb_01: ps3stor_setup:193: map DMA region failed
Signed-off-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/562d0c9ea0100a30c3b186bcc7adb34b0bbd2cd7.1622746428.git.geoff@infradead.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/powerpc/include/asm/ps3.h | 2 ++
arch/powerpc/platforms/ps3/mm.c | 12 ++++++++++++
2 files changed, 14 insertions(+)
diff --git a/arch/powerpc/include/asm/ps3.h b/arch/powerpc/include/asm/ps3.h
index e646c7f218bc..12b6b76e8d0f 100644
--- a/arch/powerpc/include/asm/ps3.h
+++ b/arch/powerpc/include/asm/ps3.h
@@ -71,6 +71,7 @@ struct ps3_dma_region_ops;
* @bus_addr: The 'translated' bus address of the region.
* @len: The length in bytes of the region.
* @offset: The offset from the start of memory of the region.
+ * @dma_mask: Device dma_mask.
* @ioid: The IOID of the device who owns this region
* @chunk_list: Opaque variable used by the ioc page manager.
* @region_ops: struct ps3_dma_region_ops - dma region operations
@@ -85,6 +86,7 @@ struct ps3_dma_region {
enum ps3_dma_region_type region_type;
unsigned long len;
unsigned long offset;
+ u64 dma_mask;
/* driver variables (set by ps3_dma_region_create) */
unsigned long bus_addr;
diff --git a/arch/powerpc/platforms/ps3/mm.c b/arch/powerpc/platforms/ps3/mm.c
index d094321964fb..a81eac35d900 100644
--- a/arch/powerpc/platforms/ps3/mm.c
+++ b/arch/powerpc/platforms/ps3/mm.c
@@ -6,6 +6,7 @@
* Copyright 2006 Sony Corp.
*/
+#include <linux/dma-mapping.h>
#include <linux/kernel.h>
#include <linux/export.h>
#include <linux/memblock.h>
@@ -1118,6 +1119,7 @@ int ps3_dma_region_init(struct ps3_system_bus_device *dev,
enum ps3_dma_region_type region_type, void *addr, unsigned long len)
{
unsigned long lpar_addr;
+ int result;
lpar_addr = addr ? ps3_mm_phys_to_lpar(__pa(addr)) : 0;
@@ -1129,6 +1131,16 @@ int ps3_dma_region_init(struct ps3_system_bus_device *dev,
r->offset -= map.r1.offset;
r->len = len ? len : ALIGN(map.total, 1 << r->page_size);
+ dev->core.dma_mask = &r->dma_mask;
+
+ result = dma_set_mask_and_coherent(&dev->core, DMA_BIT_MASK(32));
+
+ if (result < 0) {
+ dev_err(&dev->core, "%s:%d: dma_set_mask_and_coherent failed: %d\n",
+ __func__, __LINE__, result);
+ return result;
+ }
+
switch (dev->dev_type) {
case PS3_DEVICE_TYPE_SB:
r->region_ops = (USE_DYNAMIC_DMA)
--
2.30.2
next prev parent reply other threads:[~2021-07-10 2:23 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 2:20 [PATCH AUTOSEL 5.12 001/104] leds: tlc591xx: fix return value check in tlc591xx_probe() Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 002/104] ASoC: Intel: sof_sdw: add mutual exclusion between PCH DMIC and RT715 Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 003/104] ASoC: Intel: sof_sdw: add SOF_RT715_DAI_ID_FIX for AlderLake Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 004/104] dmaengine: fsl-qdma: check dma_set_mask return value Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 005/104] scsi: arcmsr: Fix the wrong CDB payload report to IOP Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 006/104] srcu: Fix broken node geometry after early ssp init Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 007/104] rcu: Reject RCU_LOCKDEP_WARN() false positives Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 008/104] usb: dwc3: pci: Fix DEFINE for Intel Elkhart Lake Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 009/104] tty: serial: fsl_lpuart: fix the potential risk of division or modulo by zero Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 010/104] serial: fsl_lpuart: disable DMA for console and fix sysrq Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 011/104] serial: 8250: of: Check for CONFIG_SERIAL_8250_BCM7271 Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 012/104] misc/libmasm/module: Fix two use after free in ibmasm_init_one Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 013/104] misc: alcor_pci: fix null-ptr-deref when there is no PCI bridge Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 014/104] ASoC: intel/boards: add missing MODULE_DEVICE_TABLE Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 015/104] partitions: msdos: fix one-byte get_unaligned() Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 016/104] iio: imu: st_lsm6dsx: correct ODR in header Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 017/104] iio: gyro: fxa21002c: Balance runtime pm + use pm_runtime_resume_and_get() Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 018/104] iio: magn: bmc150: " Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 019/104] ALSA: usx2y: Avoid camelCase Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 020/104] ALSA: usx2y: Don't call free_pages_exact() with NULL address Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 021/104] Revert "ALSA: bebob/oxfw: fix Kconfig entry for Mackie d.2 Pro" Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 022/104] usb: common: usb-conn-gpio: fix NULL pointer dereference of charger Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 023/104] w1: ds2438: fixing bug that would always get page0 Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 024/104] ASoC: Intel: sof_sdw: add quirk support for Brya and BT-offload Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 025/104] scsi: arcmsr: Fix doorbell status being updated late on ARC-1886 Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 026/104] scsi: hisi_sas: Propagate errors in interrupt_init_v1_hw() Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 027/104] scsi: lpfc: Fix "Unexpected timeout" error in direct attach topology Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 028/104] scsi: lpfc: Fix crash when lpfc_sli4_hba_setup() fails to initialize the SGLs Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 029/104] scsi: core: Cap scsi_host cmd_per_lun at can_queue Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 030/104] ALSA: ac97: fix PM reference leak in ac97_bus_remove() Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 031/104] tty: serial: 8250: serial_cs: Fix a memory leak in error handling path Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 032/104] scsi: mpt3sas: Fix deadlock while cancelling the running firmware event Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 033/104] scsi: core: Fixup calling convention for scsi_mode_sense() Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 034/104] scsi: scsi_dh_alua: Check for negative result value Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 035/104] fs/jfs: Fix missing error code in lmLogInit() Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 036/104] scsi: megaraid_sas: Fix resource leak in case of probe failure Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 037/104] scsi: megaraid_sas: Early detection of VD deletion through RaidMap update Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 038/104] scsi: megaraid_sas: Handle missing interrupts while re-enabling IRQs Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 039/104] scsi: iscsi: Stop queueing during ep_disconnect Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 040/104] scsi: iscsi: Add iscsi_cls_conn refcount helpers Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 041/104] scsi: iscsi: Fix conn use after free during resets Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 042/104] scsi: iscsi: Fix shost->max_id use Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 043/104] scsi: qedi: Fix null ref during abort handling Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 044/104] scsi: qedi: Fix race during abort timeouts Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 045/104] scsi: qedi: Fix TMF session block/unblock use Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 046/104] scsi: qedi: Fix cleanup " Sasha Levin
2021-07-10 2:20 ` [PATCH AUTOSEL 5.12 047/104] mfd: da9052/stmpe: Add and modify MODULE_DEVICE_TABLE Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 048/104] mfd: cpcap: Fix cpcap dmamask not set warnings Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 049/104] char: xillybus: Fix condition for invoking the xillybus/ subdirectory Sasha Levin
2021-07-10 5:16 ` Eli Billauer
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 050/104] ASoC: img: Fix PM reference leak in img_i2s_in_probe() Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 051/104] fsi: Add missing MODULE_DEVICE_TABLE Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 052/104] serial: tty: uartlite: fix console setup Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 053/104] s390/sclp_vt220: fix console name to match device Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 054/104] s390: disable SSP when needed Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 055/104] selftests: timers: rtcpie: skip test if default RTC device does not exist Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 056/104] iommu/arm-smmu-qcom: Skip the TTBR1 quirk for db820c Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 057/104] USB: core: Avoid WARNings for 0-length descriptor requests Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 058/104] ALSA: sb: Fix potential double-free of CSP mixer elements Sasha Levin
2021-07-10 2:21 ` Sasha Levin [this message]
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 060/104] iommu/arm-smmu: Fix arm_smmu_device refcount leak when arm_smmu_rpm_get fails Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 061/104] iommu/arm-smmu: Fix arm_smmu_device refcount leak in address translation Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 062/104] ALSA: n64: check return value after calling platform_get_resource() Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 063/104] ASoC: soc-pcm: fix the return value in dpcm_apply_symmetry() Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 064/104] gpio: zynq: Check return value of pm_runtime_get_sync Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 065/104] gpio: zynq: Check return value of irq_get_irq_data Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 066/104] scsi: storvsc: Correctly handle multiple flags in srb_status Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 067/104] ALSA: ppc: fix error return code in snd_pmac_probe() Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 068/104] selftests/powerpc: Fix "no_handler" EBB selftest Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 069/104] gpio: pca953x: Add support for the On Semi pca9655 Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 070/104] powerpc/mm/book3s64: Fix possible build error Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 071/104] ASoC: soc-core: Fix the error return code in snd_soc_of_parse_audio_routing() Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 072/104] xhci: handle failed buffer copy to URB sg list and fix a W=1 copiler warning Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 073/104] habanalabs/gaudi: set the correct cpu_id on MME2_QM failure Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 074/104] habanalabs: fix mask to obtain page offset Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 075/104] habanalabs: set rc as 'valid' in case of intentional func exit Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 076/104] habanalabs: remove node from list before freeing the node Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 077/104] habanalabs/gaudi: set the correct rc in case of err Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 078/104] s390/processor: always inline stap() and __load_psw_mask() Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 079/104] s390/ipl_parm: fix program check new psw handling Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 080/104] s390/mem_detect: fix diag260() " Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 081/104] s390/mem_detect: fix tprot() " Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 082/104] Input: hideep - fix the uninitialized use in hideep_nvm_unlock() Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 083/104] ALSA: bebob: add support for ToneWeal FW66 Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 084/104] m68knommu: fix missing LCD splash screen data initializer Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 085/104] ALSA: usb-audio: scarlett2: Fix 18i8 Gen 2 PCM Input count Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 086/104] ALSA: usb-audio: scarlett2: Fix data_mutex lock Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 087/104] ALSA: usb-audio: scarlett2: Fix scarlett2_*_ctl_put() return values Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 088/104] usb: gadget: f_hid: fix endianness issue with descriptors Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 089/104] usb: gadget: hid: fix error return code in hid_bind() Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 090/104] powerpc/boot: Fixup device-tree on little endian Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 091/104] ASoC: fsl_xcvr: check return value after calling platform_get_resource_byname() Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 092/104] ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 093/104] backlight: lm3630a: Fix return code of .update_status() callback Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 094/104] ALSA: hda: Add IRQ check for platform_get_irq() Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 095/104] ALSA: usb-audio: scarlett2: Fix 6i6 Gen 2 line out descriptions Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 096/104] ALSA: firewire-motu: fix detection for S/PDIF source on optical interface in v2 protocol Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 097/104] jfs: fix GPF in diFree Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 098/104] leds: turris-omnia: add missing MODULE_DEVICE_TABLE Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 099/104] staging: rtl8723bs: fix macro value for 2.4Ghz only device Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 100/104] intel_th: Wait until port is in reset before programming it Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 101/104] i2c: core: Disable client irq on reboot/shutdown Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 102/104] phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 103/104] lib/decompress_unlz4.c: correctly handle zero-padding around initrds Sasha Levin
2021-07-10 2:21 ` [PATCH AUTOSEL 5.12 104/104] kcov: add __no_sanitize_coverage to fix noinstr for all architectures Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210710022156.3168825-59-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=geoff@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox