From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F27BC4320A for ; Fri, 23 Jul 2021 03:58:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 290FB60EE2 for ; Fri, 23 Jul 2021 03:58:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234285AbhGWDSO (ORCPT ); Thu, 22 Jul 2021 23:18:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:38070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234180AbhGWDRy (ORCPT ); Thu, 22 Jul 2021 23:17:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5003760F38; Fri, 23 Jul 2021 03:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627012709; bh=ndx/mOGnLOhap9xANN6K1vSFYUJd4L64EZ5R6OEr5Zc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rtPhaU+udVarx//W88xbO13IXlo5re2XIEIYoeHZEdDV2PZgUoEMQdeXgXMvKKZr2 3gObNV3sov7n514NzcL0dRX1xzsifq/Ee8YCbMQ0b4uXaKw4B0q7Jvr2bcoJm7uXjf 8mGQVY2BTiyMN5pV2DyJRceULv8HpJzauOMci2ZZ+3UubfT/pzjUXKKNRmaVep+lQR Ihc26T0IMAxbBaSBlSY9mtuzA0jnoGaoVmTiXWJCmYB3oFKN9fXWR18U7jO9Prm3+C Md+xAlwVwPpJhzq01GxrXS8VSyfJGBemJD4kF4qJFTDqRY3v5rwWYTs+FkPcaSIdWw IL5VddwfFPPTw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Cristian Marussi , Vincent Guittot , Sudeep Holla , Sasha Levin , linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 10/14] firmware: arm_scmi: Fix range check for the maximum number of pending messages Date: Thu, 22 Jul 2021 23:58:09 -0400 Message-Id: <20210723035813.531837-10-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210723035813.531837-1-sashal@kernel.org> References: <20210723035813.531837-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Cristian Marussi [ Upstream commit bdb8742dc6f7c599c3d61959234fe4c23638727b ] SCMI message headers carry a sequence number and such field is sized to allow for MSG_TOKEN_MAX distinct numbers; moreover zero is not really an acceptable maximum number of pending in-flight messages. Fix accordingly the checks performed on the value exported by transports in scmi_desc.max_msg Link: https://lore.kernel.org/r/20210712141833.6628-3-cristian.marussi@arm.com Reported-by: Vincent Guittot Signed-off-by: Cristian Marussi [sudeep.holla: updated the patch title and error message] Signed-off-by: Sudeep Holla Signed-off-by: Sasha Levin --- drivers/firmware/arm_scmi/driver.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 629f57795a9b..551672aecd2c 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -690,8 +690,9 @@ static int scmi_xfer_info_init(struct scmi_info *sinfo) struct scmi_xfers_info *info = &sinfo->tx_minfo; /* Pre-allocated messages, no more than what hdr.seq can support */ - if (WARN_ON(desc->max_msg >= MSG_TOKEN_MAX)) { - dev_err(dev, "Maximum message of %d exceeds supported %ld\n", + if (WARN_ON(!desc->max_msg || desc->max_msg > MSG_TOKEN_MAX)) { + dev_err(dev, + "Invalid maximum messages %d, not in range [1 - %lu]\n", desc->max_msg, MSG_TOKEN_MAX); return -EINVAL; } -- 2.30.2