* [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks [not found] <20210820135707.171001-1-jlayton@kernel.org> @ 2021-08-20 13:57 ` Jeff Layton 2021-08-20 15:49 ` David Laight 2021-08-20 15:52 ` David Hildenbrand 0 siblings, 2 replies; 6+ messages in thread From: Jeff Layton @ 2021-08-20 13:57 UTC (permalink / raw) To: torvalds, linux-fsdevel, linux-kernel Cc: ebiederm, david, willy, linux-nfs, viro, linux-doc, v9fs-developer, linux-afs, cluster-devel, ocfs2-devel, linux-mm, akpm, luto, bfields, w, rostedt, stable We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros have disabled it. Warn the stragglers that still use "-o mand" that we'll be dropping support for that mount option. Cc: stable@vger.kernel.org Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/namespace.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/namespace.c b/fs/namespace.c index ab4174a3c802..ffab0bb1e649 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -1716,8 +1716,16 @@ static inline bool may_mount(void) } #ifdef CONFIG_MANDATORY_FILE_LOCKING +static bool warned_mand; static inline bool may_mandlock(void) { + if (!warned_mand) { + warned_mand = true; + pr_warn("======================================================\n"); + pr_warn("WARNING: the mand mount option is being deprecated and\n"); + pr_warn(" will be removed in v5.15!\n"); + pr_warn("======================================================\n"); + } return capable(CAP_SYS_ADMIN); } #else -- 2.31.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks 2021-08-20 13:57 ` [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks Jeff Layton @ 2021-08-20 15:49 ` David Laight 2021-08-20 15:50 ` Jeff Layton 2021-08-20 15:52 ` David Hildenbrand 1 sibling, 1 reply; 6+ messages in thread From: David Laight @ 2021-08-20 15:49 UTC (permalink / raw) To: 'Jeff Layton', torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ebiederm@xmission.com, david@redhat.com, willy@infradead.org, linux-nfs@vger.kernel.org, viro@zeniv.linux.org.uk, linux-doc@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, akpm@linux-foundation.org, luto@kernel.org, bfields@fieldses.org, w@1wt.eu, rostedt@goodmis.org, stable@vger.kernel.org From: Jeff Layton > Sent: 20 August 2021 14:57 > > We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros > have disabled it. Warn the stragglers that still use "-o mand" that > we'll be dropping support for that mount option. > > Cc: stable@vger.kernel.org > Signed-off-by: Jeff Layton <jlayton@kernel.org> > --- > fs/namespace.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/fs/namespace.c b/fs/namespace.c > index ab4174a3c802..ffab0bb1e649 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -1716,8 +1716,16 @@ static inline bool may_mount(void) > } > > #ifdef CONFIG_MANDATORY_FILE_LOCKING > +static bool warned_mand; > static inline bool may_mandlock(void) > { > + if (!warned_mand) { > + warned_mand = true; > + pr_warn("======================================================\n"); > + pr_warn("WARNING: the mand mount option is being deprecated and\n"); > + pr_warn(" will be removed in v5.15!\n"); > + pr_warn("======================================================\n"); > + } > return capable(CAP_SYS_ADMIN); > } If that is called more than once you don't want the 'inline'. I doubt it matters is not inlined - hardly a hot path. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks 2021-08-20 15:49 ` David Laight @ 2021-08-20 15:50 ` Jeff Layton 0 siblings, 0 replies; 6+ messages in thread From: Jeff Layton @ 2021-08-20 15:50 UTC (permalink / raw) To: David Laight, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ebiederm@xmission.com, david@redhat.com, willy@infradead.org, linux-nfs@vger.kernel.org, viro@zeniv.linux.org.uk, linux-doc@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, akpm@linux-foundation.org, luto@kernel.org, bfields@fieldses.org, w@1wt.eu, rostedt@goodmis.org, stable@vger.kernel.org On Fri, 2021-08-20 at 15:49 +0000, David Laight wrote: > From: Jeff Layton > > Sent: 20 August 2021 14:57 > > > > We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros > > have disabled it. Warn the stragglers that still use "-o mand" that > > we'll be dropping support for that mount option. > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Jeff Layton <jlayton@kernel.org> > > --- > > fs/namespace.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/fs/namespace.c b/fs/namespace.c > > index ab4174a3c802..ffab0bb1e649 100644 > > --- a/fs/namespace.c > > +++ b/fs/namespace.c > > @@ -1716,8 +1716,16 @@ static inline bool may_mount(void) > > } > > > > #ifdef CONFIG_MANDATORY_FILE_LOCKING > > +static bool warned_mand; > > static inline bool may_mandlock(void) > > { > > + if (!warned_mand) { > > + warned_mand = true; > > + pr_warn("======================================================\n"); > > + pr_warn("WARNING: the mand mount option is being deprecated and\n"); > > + pr_warn(" will be removed in v5.15!\n"); > > + pr_warn("======================================================\n"); > > + } > > return capable(CAP_SYS_ADMIN); > > } > > If that is called more than once you don't want the 'inline'. > I doubt it matters is not inlined - hardly a hot path. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) > ACK. Of course. That really needs to not be inline. I'll fix that up in my tree. Thanks! -- Jeff Layton <jlayton@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks 2021-08-20 13:57 ` [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks Jeff Layton 2021-08-20 15:49 ` David Laight @ 2021-08-20 15:52 ` David Hildenbrand 2021-08-20 16:06 ` Jeff Layton 2021-08-20 16:08 ` Steven Rostedt 1 sibling, 2 replies; 6+ messages in thread From: David Hildenbrand @ 2021-08-20 15:52 UTC (permalink / raw) To: Jeff Layton, torvalds, linux-fsdevel, linux-kernel Cc: ebiederm, willy, linux-nfs, viro, linux-doc, v9fs-developer, linux-afs, cluster-devel, ocfs2-devel, linux-mm, akpm, luto, bfields, w, rostedt, stable On 20.08.21 15:57, Jeff Layton wrote: > We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros > have disabled it. Warn the stragglers that still use "-o mand" that > we'll be dropping support for that mount option. > > Cc: stable@vger.kernel.org > Signed-off-by: Jeff Layton <jlayton@kernel.org> > --- > fs/namespace.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/fs/namespace.c b/fs/namespace.c > index ab4174a3c802..ffab0bb1e649 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -1716,8 +1716,16 @@ static inline bool may_mount(void) > } > > #ifdef CONFIG_MANDATORY_FILE_LOCKING > +static bool warned_mand; > static inline bool may_mandlock(void) > { > + if (!warned_mand) { > + warned_mand = true; > + pr_warn("======================================================\n"); > + pr_warn("WARNING: the mand mount option is being deprecated and\n"); > + pr_warn(" will be removed in v5.15!\n"); > + pr_warn("======================================================\n"); > + } Is there a reason not to use pr_warn_once() ? -- Thanks, David / dhildenb ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks 2021-08-20 15:52 ` David Hildenbrand @ 2021-08-20 16:06 ` Jeff Layton 2021-08-20 16:08 ` Steven Rostedt 1 sibling, 0 replies; 6+ messages in thread From: Jeff Layton @ 2021-08-20 16:06 UTC (permalink / raw) To: David Hildenbrand, torvalds, linux-fsdevel, linux-kernel Cc: ebiederm, willy, linux-nfs, viro, linux-doc, v9fs-developer, linux-afs, cluster-devel, ocfs2-devel, linux-mm, akpm, luto, bfields, w, rostedt, stable On Fri, 2021-08-20 at 17:52 +0200, David Hildenbrand wrote: > On 20.08.21 15:57, Jeff Layton wrote: > > We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros > > have disabled it. Warn the stragglers that still use "-o mand" that > > we'll be dropping support for that mount option. > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Jeff Layton <jlayton@kernel.org> > > --- > > fs/namespace.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/fs/namespace.c b/fs/namespace.c > > index ab4174a3c802..ffab0bb1e649 100644 > > --- a/fs/namespace.c > > +++ b/fs/namespace.c > > @@ -1716,8 +1716,16 @@ static inline bool may_mount(void) > > } > > > > #ifdef CONFIG_MANDATORY_FILE_LOCKING > > +static bool warned_mand; > > static inline bool may_mandlock(void) > > { > > + if (!warned_mand) { > > + warned_mand = true; > > + pr_warn("======================================================\n"); > > + pr_warn("WARNING: the mand mount option is being deprecated and\n"); > > + pr_warn(" will be removed in v5.15!\n"); > > + pr_warn("======================================================\n"); > > + } > > Is there a reason not to use pr_warn_once() ? > > No reason at all. I'll send out a v3 set in a bit with that change. Thanks! -- Jeff Layton <jlayton@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks 2021-08-20 15:52 ` David Hildenbrand 2021-08-20 16:06 ` Jeff Layton @ 2021-08-20 16:08 ` Steven Rostedt 1 sibling, 0 replies; 6+ messages in thread From: Steven Rostedt @ 2021-08-20 16:08 UTC (permalink / raw) To: David Hildenbrand Cc: Jeff Layton, torvalds, linux-fsdevel, linux-kernel, ebiederm, willy, linux-nfs, viro, linux-doc, v9fs-developer, linux-afs, cluster-devel, ocfs2-devel, linux-mm, akpm, luto, bfields, w, stable On Fri, 20 Aug 2021 17:52:19 +0200 David Hildenbrand <david@redhat.com> wrote: > > +static bool warned_mand; > > static inline bool may_mandlock(void) > > { > > + if (!warned_mand) { > > + warned_mand = true; > > + pr_warn("======================================================\n"); > > + pr_warn("WARNING: the mand mount option is being deprecated and\n"); > > + pr_warn(" will be removed in v5.15!\n"); > > + pr_warn("======================================================\n"); > > + } > > Is there a reason not to use pr_warn_once() ? You would need a single call though, otherwise each pr_warn_once() would have its own state that it warned once. const char warning[] = "======================================================\n" "WARNING: the mand mount option is being deprecated and\n" " will be removed in v5.15!\n" "======================================================\n"; pr_warn_once(warning); -- Steve ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-20 16:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210820135707.171001-1-jlayton@kernel.org>
2021-08-20 13:57 ` [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks Jeff Layton
2021-08-20 15:49 ` David Laight
2021-08-20 15:50 ` Jeff Layton
2021-08-20 15:52 ` David Hildenbrand
2021-08-20 16:06 ` Jeff Layton
2021-08-20 16:08 ` Steven Rostedt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox