From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B89A6C4332F for ; Mon, 6 Sep 2021 01:32:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A069860F22 for ; Mon, 6 Sep 2021 01:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243514AbhIFBdD (ORCPT ); Sun, 5 Sep 2021 21:33:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:48676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351566AbhIFBal (ORCPT ); Sun, 5 Sep 2021 21:30:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 905C8610E7; Mon, 6 Sep 2021 01:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630891438; bh=+bev58bVKwRrcOyb0CjLvJuGlpklQmuYyABCx8sCT1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eoGTuqXEEXZxj75F3OGaY1/dmcu+NBYaMAKFyPZtSNA3cC3h1H/1PTrVHyrHimUwr j30LPJw9W0Zejb4lTWifPaIDyjCry8yr2XtA06Fjuumir6juLW0FIeOZgZZ6In2Tpl 9PE/JCc/gg2rYIsVjAxg+rpNy+nfXFl654E/J+9ieLbIb901PjiCr+VHKP0sd5Hcqy k5WSsPB0g7No0O0XMAVQMNfwAuG8mAyoIVA/DYQxn6C+rRua6bxQ+kRUbB9+WxH3hR 2qrZjO2T7KuFMI8HVcsHNuKbDOqklNHsw1D593xfOvCf30AvoxqxfWlbyhHeTRPDfw FaNNbmpPHcJHQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tony Lindgren , Lokesh Vutla , Tero Kristo , Herbert Xu , Sasha Levin , linux-crypto@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 04/17] crypto: omap-sham - clear dma flags only after omap_sham_update_dma_stop() Date: Sun, 5 Sep 2021 21:23:39 -0400 Message-Id: <20210906012352.930954-4-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210906012352.930954-1-sashal@kernel.org> References: <20210906012352.930954-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tony Lindgren [ Upstream commit fe28140b3393b0ba1eb95cc109f974a7e58b26fd ] We should not clear FLAGS_DMA_ACTIVE before omap_sham_update_dma_stop() is done calling dma_unmap_sg(). We already clear FLAGS_DMA_ACTIVE at the end of omap_sham_update_dma_stop(). The early clearing of FLAGS_DMA_ACTIVE is not causing issues as we do not need to defer anything based on FLAGS_DMA_ACTIVE currently. So this can be applied as clean-up. Cc: Lokesh Vutla Cc: Tero Kristo Signed-off-by: Tony Lindgren Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/omap-sham.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index e34e9561e77d..adf958956982 100644 --- a/drivers/crypto/omap-sham.c +++ b/drivers/crypto/omap-sham.c @@ -1746,7 +1746,7 @@ static void omap_sham_done_task(unsigned long data) if (test_and_clear_bit(FLAGS_OUTPUT_READY, &dd->flags)) goto finish; } else if (test_bit(FLAGS_DMA_READY, &dd->flags)) { - if (test_and_clear_bit(FLAGS_DMA_ACTIVE, &dd->flags)) { + if (test_bit(FLAGS_DMA_ACTIVE, &dd->flags)) { omap_sham_update_dma_stop(dd); if (dd->err) { err = dd->err; -- 2.30.2