From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <stable@vger.kernel.org>,
"Li Qiang (Johnny Li)" <johnny.li@montage-tech.com>,
<alison.schofield@intel.com>, <ben.widawsky@intel.com>
Subject: Re: [PATCH 3/6] cxl/pci: Fix debug message in cxl_probe_regs()
Date: Mon, 6 Sep 2021 10:04:10 +0100 [thread overview]
Message-ID: <20210906100410.00003d5b@Huawei.com> (raw)
In-Reply-To: <163072205089.2250120.8103605864156687395.stgit@dwillia2-desk3.amr.corp.intel.com>
On Fri, 3 Sep 2021 19:20:50 -0700
Dan Williams <dan.j.williams@intel.com> wrote:
> From: Li Qiang (Johnny Li) <johnny.li@montage-tech.com>
>
> Indicator string for mbox and memdev register set to status
> incorrectly in error message.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 30af97296f48 ("cxl/pci: Map registers based on capabilities")
> Signed-off-by: Li Qiang (Johnny Li) <johnny.li@montage-tech.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
fwiw obviously correct.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/cxl/pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index 37903259ee79..8e45aa07d662 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -1041,8 +1041,8 @@ static int cxl_probe_regs(struct cxl_mem *cxlm, void __iomem *base,
> !dev_map->memdev.valid) {
> dev_err(dev, "registers not found: %s%s%s\n",
> !dev_map->status.valid ? "status " : "",
> - !dev_map->mbox.valid ? "status " : "",
> - !dev_map->memdev.valid ? "status " : "");
> + !dev_map->mbox.valid ? "mbox " : "",
> + !dev_map->memdev.valid ? "memdev " : "");
> return -ENXIO;
> }
>
>
prev parent reply other threads:[~2021-09-06 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 2:20 [PATCH 0/6] cxl fixes for v5.15-rc1 Dan Williams
2021-09-04 2:20 ` [PATCH 1/6] cxl/acpi: Do not add DSDT disabled ACPI0016 host bridge ports Dan Williams
2021-09-04 2:20 ` [PATCH 2/6] cxl/pci: Fix lockdown level Dan Williams
2021-09-04 3:57 ` Paul Moore
2021-09-07 17:38 ` Dan Williams
2021-09-07 19:46 ` Paul Moore
2021-09-10 12:55 ` Ondrej Mosnacek
2021-09-10 14:56 ` Dan Williams
2021-09-10 17:46 ` Paul Moore
2021-09-04 2:20 ` [PATCH 3/6] cxl/pci: Fix debug message in cxl_probe_regs() Dan Williams
2021-09-06 9:04 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906100410.00003d5b@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=johnny.li@montage-tech.com \
--cc=linux-cxl@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox