From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B232C433EF for ; Fri, 10 Sep 2021 00:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46E726115A for ; Fri, 10 Sep 2021 00:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232978AbhIJAoI (ORCPT ); Thu, 9 Sep 2021 20:44:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:46072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233401AbhIJATv (ORCPT ); Thu, 9 Sep 2021 20:19:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CB147610E9; Fri, 10 Sep 2021 00:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233120; bh=CaIja6IPejWfnxudbYGFoxFgiIuaZH/AxSaHWzrCUn8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DQMarhAK6YGqzLACpFMXJr+a6JKORScyHEVGMX7m5ToMsAUw01OOtkg3pXUdaH9Xz 9POqpnFPJd36iGefX2NQxU6IO5G1GXE4drY6iVvI/r4XZfZICTnKM2agab+ryIo7nY 1nxNpMfwORUCncuSdnHv3JKqg8OWcqkASpi4shj3ZEOcKJCKufrs3fjbSHS4actAAZ iUgClEppe3hQWm06oa34b3/H7TMdmIuapVswTTMRJUoOOkPYF3vvDTT0SwHe8N1u8P 3UXggzjb2fa5HmBiorcF5UZpmf/gRQeOZdSHaoRvwMoW02kYu3M9xXVKO8R9kHmlnL 1AtTOS59RZ6AA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mike McGowen , Kevin Barnett , Scott Benesh , Scott Teel , Don Brace , "Martin K . Petersen" , Sasha Levin , storagedev@microchip.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.13 14/88] scsi: smartpqi: Fix ISR accessing uninitialized data Date: Thu, 9 Sep 2021 20:17:06 -0400 Message-Id: <20210910001820.174272-14-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910001820.174272-1-sashal@kernel.org> References: <20210910001820.174272-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Mike McGowen [ Upstream commit 0777a3fb98f0ea546561d04db4fd325248c39961 ] Correct driver's ISR accessing a data structure member that has not been fully initialized during driver initialization. The pqi queue groups can have uninitialized members when an interrupt fires. This has not resulted in any driver crashes. This was found during our own internal testing. No bugs were ever filed. Link: https://lore.kernel.org/r/20210714182847.50360-9-don.brace@microchip.com Reviewed-by: Kevin Barnett Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Mike McGowen Signed-off-by: Don Brace Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/smartpqi/smartpqi_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 5db16509b6e1..051f3da288d4 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -7759,11 +7759,11 @@ static int pqi_ctrl_init(struct pqi_ctrl_info *ctrl_info) pqi_init_operational_queues(ctrl_info); - rc = pqi_request_irqs(ctrl_info); + rc = pqi_create_queues(ctrl_info); if (rc) return rc; - rc = pqi_create_queues(ctrl_info); + rc = pqi_request_irqs(ctrl_info); if (rc) return rc; -- 2.30.2