From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C73C433FE for ; Fri, 10 Sep 2021 00:44:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C2096115A for ; Fri, 10 Sep 2021 00:44:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232435AbhIJAps (ORCPT ); Thu, 9 Sep 2021 20:45:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:47522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233810AbhIJAVo (ORCPT ); Thu, 9 Sep 2021 20:21:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 19FF6610A3; Fri, 10 Sep 2021 00:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233234; bh=fTcZ3cYtTT+hrBpIaRoONPfiCMU7LCbwOJh9LibM75A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OsU3vSSlKErm+a3GxToor/YiOr2UIkQ0eay7hHt/Y+Tsrr0yFd7rysjxUowDU+GGs GCbjeIkW+Qi7AfiEUQo42N/C8lUskPg1JbT3dJ6xBYNKmdDNrMJuG1/Ey0ct+0ai3L jn6cPYHtScAprVpkuIkaUKsZGml+T/U7NJ6oIe85xmBCzWPlpgtiPI9eW2pyUVF6PR Vdy2hGR5flRTnaMKgLoPhysi7KIaBqpfJyRZ1AaPjrV/89z1ZRlJ5cYO7kXK/o0INP bVg2YHdhMLl/KW9Wb60LW/ksoQQ6WTzOHAf1tmkd3NQqlht4rhnjo/R7YmdDM/hAMf h5+AERD2QTXaw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia Yang , Chao Yu , Jaegeuk Kim , Sasha Levin , linux-f2fs-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.10 04/53] f2fs: Revert "f2fs: Fix indefinite loop in f2fs_gc() v1" Date: Thu, 9 Sep 2021 20:19:39 -0400 Message-Id: <20210910002028.175174-4-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910002028.175174-1-sashal@kernel.org> References: <20210910002028.175174-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jia Yang [ Upstream commit 10d0786b39b3b91c4fbf8c2926e97ab456a4eea1 ] This reverts commit 957fa47823dfe449c5a15a944e4e7a299a6601db. The patch "f2fs: Fix indefinite loop in f2fs_gc()" v1 and v4 are all merged. Patch v4 is test info for patch v1. Patch v1 doesn't work and may cause that sbi->cur_victim_sec can't be resetted to NULL_SEGNO, which makes SSR unable to get segment of sbi->cur_victim_sec. So it should be reverted. The mails record: [1] https://lore.kernel.org/linux-f2fs-devel/7288dcd4-b168-7656-d1af-7e2cafa4f720@huawei.com/T/ [2] https://lore.kernel.org/linux-f2fs-devel/20190809153653.GD93481@jaegeuk-macbookpro.roam.corp.google.com/T/ Signed-off-by: Jia Yang Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/gc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index e02affb5c0e7..343b9baf0d08 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1727,7 +1727,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, round++; } - if (gc_type == FG_GC && seg_freed) + if (gc_type == FG_GC) sbi->cur_victim_sec = NULL_SEGNO; if (sync) -- 2.30.2