From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11148C433EF for ; Fri, 24 Sep 2021 12:47:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F085461265 for ; Fri, 24 Sep 2021 12:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344346AbhIXMtX (ORCPT ); Fri, 24 Sep 2021 08:49:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:42730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344223AbhIXMsh (ORCPT ); Fri, 24 Sep 2021 08:48:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DFD316124C; Fri, 24 Sep 2021 12:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632487624; bh=SzRhX6bMighsIpJi2KT6RB9G710ii7c0AsCpSyB7/us=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JVxeJ2Q6JzSdOrb5KTfaPndi8Karxn8egGIe3hxfixyimj3lgXSs6GhpHORdC8UiB 9YL5U296Y8JrE6GcKaw7o2fuNtn1en2Cp6VWLlfpHV6Iu6wQEQL23ujjll8qE4CUPV EEDfEBisKUlA4K2ss11ndTQxTVYKKuMoy45EE6lY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marcelo Ricardo Leitner , "David S. Miller" Subject: [PATCH 4.14 05/27] sctp: validate chunk size in __rcv_asconf_lookup Date: Fri, 24 Sep 2021 14:43:59 +0200 Message-Id: <20210924124329.355681505@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210924124329.173674820@linuxfoundation.org> References: <20210924124329.173674820@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marcelo Ricardo Leitner commit b6ffe7671b24689c09faa5675dd58f93758a97ae upstream. In one of the fallbacks that SCTP has for identifying an association for an incoming packet, it looks for AddIp chunk (from ASCONF) and take a peek. Thing is, at this stage nothing was validating that the chunk actually had enough content for that, allowing the peek to happen over uninitialized memory. Similar check already exists in actual asconf handling in sctp_verify_asconf(). Signed-off-by: Marcelo Ricardo Leitner Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sctp/input.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -1118,6 +1118,9 @@ static struct sctp_association *__sctp_r union sctp_addr_param *param; union sctp_addr paddr; + if (ntohs(ch->length) < sizeof(*asconf) + sizeof(struct sctp_paramhdr)) + return NULL; + /* Skip over the ADDIP header and find the Address parameter */ param = (union sctp_addr_param *)(asconf + 1);