From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B40EC433F5 for ; Tue, 28 Sep 2021 05:59:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30F5E611F0 for ; Tue, 28 Sep 2021 05:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239402AbhI1GA7 (ORCPT ); Tue, 28 Sep 2021 02:00:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:49038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239445AbhI1F7f (ORCPT ); Tue, 28 Sep 2021 01:59:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7CFFD61381; Tue, 28 Sep 2021 05:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632808629; bh=9uwE3HwSUBKFUSbsl4cLB2VQrqGgpAGYyb2rlPk6aaQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pqYmydta9OkoV8WPo1g8UJ+sCab7JGeRjzBsP0loFRvCYlHGxuj5gh2Y/wl3fqf2m GyhB75Kxq6k2cI/NvxQMSjRUmXX98s/4CnAke5Hi+dmXLiRxjri+gYINpHydcC8kbb gSp3yawZTKZiKo8zKkpJBSAVNrvS7bgIQWbDbuBsktqD4DhmtV1Cd1+lqiwHVlf+uS b1j+3n4d1Amelx3EIcV8mxQazIBcGW/3lBTJCW2vq0QHasaZMwrYD3FCcfrOUzZ/m2 HoNHfr0IDu9JZy+TfM4ahKpYn//ATpXxzDoBEELnmSoDaBHRwGn++1nLqhicGGM6ef wIHxjC943C3iw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Jan Kara , Sasha Levin , jack@suse.com, linux-ext4@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 04/11] ext2: fix sleeping in atomic bugs on error Date: Tue, 28 Sep 2021 01:56:57 -0400 Message-Id: <20210928055704.172814-4-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210928055704.172814-1-sashal@kernel.org> References: <20210928055704.172814-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit 372d1f3e1bfede719864d0d1fbf3146b1e638c88 ] The ext2_error() function syncs the filesystem so it sleeps. The caller is holding a spinlock so it's not allowed to sleep. ext2_statfs() <- disables preempt -> ext2_count_free_blocks() -> ext2_get_group_desc() Fix this by using WARN() to print an error message and a stack trace instead of using ext2_error(). Link: https://lore.kernel.org/r/20210921203233.GA16529@kili Signed-off-by: Dan Carpenter Signed-off-by: Jan Kara Signed-off-by: Sasha Levin --- fs/ext2/balloc.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index e0cc55164505..abac81a2e694 100644 --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c @@ -48,10 +48,9 @@ struct ext2_group_desc * ext2_get_group_desc(struct super_block * sb, struct ext2_sb_info *sbi = EXT2_SB(sb); if (block_group >= sbi->s_groups_count) { - ext2_error (sb, "ext2_get_group_desc", - "block_group >= groups_count - " - "block_group = %d, groups_count = %lu", - block_group, sbi->s_groups_count); + WARN(1, "block_group >= groups_count - " + "block_group = %d, groups_count = %lu", + block_group, sbi->s_groups_count); return NULL; } @@ -59,10 +58,9 @@ struct ext2_group_desc * ext2_get_group_desc(struct super_block * sb, group_desc = block_group >> EXT2_DESC_PER_BLOCK_BITS(sb); offset = block_group & (EXT2_DESC_PER_BLOCK(sb) - 1); if (!sbi->s_group_desc[group_desc]) { - ext2_error (sb, "ext2_get_group_desc", - "Group descriptor not loaded - " - "block_group = %d, group_desc = %lu, desc = %lu", - block_group, group_desc, offset); + WARN(1, "Group descriptor not loaded - " + "block_group = %d, group_desc = %lu, desc = %lu", + block_group, group_desc, offset); return NULL; } -- 2.33.0