From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 372AFC433FE for ; Mon, 4 Oct 2021 13:17:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2045661BB2 for ; Mon, 4 Oct 2021 13:17:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236239AbhJDNTP (ORCPT ); Mon, 4 Oct 2021 09:19:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:55160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236301AbhJDNRB (ORCPT ); Mon, 4 Oct 2021 09:17:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1A221611C2; Mon, 4 Oct 2021 13:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633352810; bh=omDE3SJPSI0nNgYo/PU0EBeSGvKbbk8izuJ1LC1pJ68=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cPa2jPhBGv4fzYAg6zDWGmqNhgcVJKY2fg4/AbGuFL32SmFE8nPOqkbkPbMRXaUI4 Df1udjNE44EOsXXIDe2ExX9bu6U8+yio7f5JCzRAVoc1XSGYDrRuKjilV4iolRKVfs 1nKgrfTwgcfkWDU1eW3jLFaOI8sW92Jhw2YWBIEs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Christian=20K=C3=B6nig?= , Nirmoy Das Subject: [PATCH 5.4 35/56] debugfs: debugfs_create_file_size(): use IS_ERR to check for error Date: Mon, 4 Oct 2021 14:52:55 +0200 Message-Id: <20211004125031.105052536@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211004125030.002116402@linuxfoundation.org> References: <20211004125030.002116402@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Nirmoy Das commit af505cad9567f7a500d34bf183696d570d7f6810 upstream. debugfs_create_file() returns encoded error so use IS_ERR for checking return value. Reviewed-by: Christian König Signed-off-by: Nirmoy Das Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL") Cc: stable Link: https://lore.kernel.org/r/20210902102917.2233-1-nirmoy.das@amd.com Signed-off-by: Greg Kroah-Hartman --- fs/debugfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -522,7 +522,7 @@ struct dentry *debugfs_create_file_size( { struct dentry *de = debugfs_create_file(name, mode, parent, data, fops); - if (de) + if (!IS_ERR(de)) d_inode(de)->i_size = file_size; return de; }