From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BEA7C4332F for ; Fri, 8 Oct 2021 11:31:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0962A611C3 for ; Fri, 8 Oct 2021 11:31:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241305AbhJHLdA (ORCPT ); Fri, 8 Oct 2021 07:33:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:60688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241129AbhJHLcK (ORCPT ); Fri, 8 Oct 2021 07:32:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3670C61283; Fri, 8 Oct 2021 11:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633692597; bh=hvvol/WnNDR9Ex7DOkdK4SNSSmPXLQicgu6bxiu1ou8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r13ReYLPrJ/G9r102zlMtLJCg3NbaFsIA6P7d6v3RzX0n6+4Do5kOvRhNfkjQeRzW T2RmIAVLLNSjIRD3Tc7eK8fVBxs4ERXnPox09CvuZ7IDi3V0CTaLxhMCOM1oqf+i9g E/1ofXNhWmQFMwp27K57pkd/O0stU4SQ1djECJ9I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Sasha Levin Subject: [PATCH 4.19 07/12] usb: dwc2: check return value after calling platform_get_resource() Date: Fri, 8 Oct 2021 13:27:55 +0200 Message-Id: <20211008112714.835793384@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211008112714.601107695@linuxfoundation.org> References: <20211008112714.601107695@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yang Yingliang [ Upstream commit 856e6e8e0f9300befa87dde09edb578555c99a82 ] It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20210831084236.1359677-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/dwc2/hcd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index 58e53e3d905b..22c4d554865e 100644 --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -5234,6 +5234,10 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg) hcd->has_tt = 1; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + retval = -EINVAL; + goto error1; + } hcd->rsrc_start = res->start; hcd->rsrc_len = resource_size(res); -- 2.33.0