From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E97B8C43217 for ; Fri, 8 Oct 2021 11:32:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8C8561037 for ; Fri, 8 Oct 2021 11:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240780AbhJHLeF (ORCPT ); Fri, 8 Oct 2021 07:34:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:60598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240415AbhJHLcy (ORCPT ); Fri, 8 Oct 2021 07:32:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BB79261029; Fri, 8 Oct 2021 11:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633692628; bh=MVbTWL27PvgqvTqMM9IB0J6I8H+mdPXgRuBvIV+JlSo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g632QKE/LQtsqcvsdQrPUyH91nnqDJ2YnX7ILVSkK1fiBrhdKu3YfQ+gTmRRdKbmO Lxae0/Aw/Erap8/Quwei3UMnU9qQeWJMZgwvDtjqPwjXAusf0klPQRkzrpteHFLwTK kpAER3+g7TZkDkSW+2O45UbTJHz+xRvf5rbrme50= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bart Van Assche , Christoph Hellwig , Ming Lei , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 05/16] scsi: sd: Free scsi_disk device via put_device() Date: Fri, 8 Oct 2021 13:27:55 +0200 Message-Id: <20211008112715.628236730@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211008112715.444305067@linuxfoundation.org> References: <20211008112715.444305067@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Ming Lei [ Upstream commit 265dfe8ebbabae7959060bd1c3f75c2473b697ed ] After a device is initialized via device_initialize() it should be freed via put_device(). sd_probe() currently gets this wrong, fix it up. Link: https://lore.kernel.org/r/20210906090112.531442-1-ming.lei@redhat.com Reviewed-by: Bart Van Assche Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lei Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/sd.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index f55249766d22..152b48605152 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3345,15 +3345,16 @@ static int sd_probe(struct device *dev) } device_initialize(&sdkp->dev); - sdkp->dev.parent = dev; + sdkp->dev.parent = get_device(dev); sdkp->dev.class = &sd_disk_class; dev_set_name(&sdkp->dev, "%s", dev_name(dev)); error = device_add(&sdkp->dev); - if (error) - goto out_free_index; + if (error) { + put_device(&sdkp->dev); + goto out; + } - get_device(dev); dev_set_drvdata(dev, sdkp); gd->major = sd_major((index & 0xf0) >> 4); -- 2.33.0