From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC15C4332F for ; Mon, 18 Oct 2021 13:32:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D711861373 for ; Mon, 18 Oct 2021 13:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232235AbhJRNeM (ORCPT ); Mon, 18 Oct 2021 09:34:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:42714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233054AbhJRNcX (ORCPT ); Mon, 18 Oct 2021 09:32:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0BA4861372; Mon, 18 Oct 2021 13:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634563749; bh=Nfg6DfDOjFlji1UjBLmwf4WuJV7mNphv5Ne5xefMy/w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IrTushxc2E6wIJdGWXeWwaf0SalyNj7YpokHbYrq4Mxd6DmH1RRETlQJm1gHUDDo9 i1QLbLhAwlVX8eSIWhK/ryviNoNvYY5oB1Wu4AxkdivNU+nlM4+WhOBehz46SEXQHr E6/F+egMDYkE7hsr9EP1dEoDhyEWPM05md5aocNQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Abaci Robot , chongjiapeng , "David S. Miller" Subject: [PATCH 4.19 49/50] qed: Fix missing error code in qed_slowpath_start() Date: Mon, 18 Oct 2021 15:24:56 +0200 Message-Id: <20211018132328.150096498@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211018132326.529486647@linuxfoundation.org> References: <20211018132326.529486647@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: chongjiapeng commit a5a14ea7b4e55604acb0dc9d88fdb4cb6945bc77 upstream. The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'. Eliminate the follow smatch warning: drivers/net/ethernet/qlogic/qed/qed_main.c:1298 qed_slowpath_start() warn: missing error code 'rc'. Reported-by: Abaci Robot Fixes: d51e4af5c209 ("qed: aRFS infrastructure support") Signed-off-by: chongjiapeng Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qed/qed_main.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -1067,6 +1067,7 @@ static int qed_slowpath_start(struct qed } else { DP_NOTICE(cdev, "Failed to acquire PTT for aRFS\n"); + rc = -EINVAL; goto err; } }