From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 137E1C433EF for ; Tue, 9 Nov 2021 01:14:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 027B061A0C for ; Tue, 9 Nov 2021 01:14:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241929AbhKIBQt (ORCPT ); Mon, 8 Nov 2021 20:16:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:40980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242925AbhKIBOi (ORCPT ); Mon, 8 Nov 2021 20:14:38 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F9C961353; Tue, 9 Nov 2021 01:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636419959; bh=4OooTmRztQJKUj11q08dZdpILcJXu/3V0osD63y2+JQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F64/yCvsY8O1eG93PpshnGMWICbtxgioLxFIZifOEd/el0aSVi1rHZwUpkRmoq9i3 toC1MXf29K38+k0065lVaUk8Hv/5bQWOXrFkyvmvrlA5EFF8s8To5S895bqJz6g4Zh QuRC/DhQpjE0jk7f1v81AOS++wR4UmWryntOqaBKfZW/jDNeHYmb+buwB1XoBw/rru hnCG548CzSklpfxYKUinAk2ICRnb6pGa3ZpgfThKu+mXHYVU/vnsuBaCU1zPcGAYWL mF6mP8SMLz0l7mtUM6gHLpRTYr5ZOqIvOPdtnZlwPYFBnoNKg+xwsop9SKx4aQ4WaK zt5urliOeIXFg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Anant Thazhemadam , syzbot+e27b4fd589762b0b9329@syzkaller.appspotmail.com, Sean Young , Mauro Carvalho Chehab , Sasha Levin , mchehab@kernel.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 24/47] media: usb: dvd-usb: fix uninit-value bug in dibusb_read_eeprom_byte() Date: Mon, 8 Nov 2021 12:50:08 -0500 Message-Id: <20211108175031.1190422-24-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211108175031.1190422-1-sashal@kernel.org> References: <20211108175031.1190422-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Anant Thazhemadam [ Upstream commit 899a61a3305d49e8a712e9ab20d0db94bde5929f ] In dibusb_read_eeprom_byte(), if dibusb_i2c_msg() fails, val gets assigned an value that's not properly initialized. Using kzalloc() in place of kmalloc() for the buffer fixes this issue, as the val can now be set to 0 in the event dibusb_i2c_msg() fails. Reported-by: syzbot+e27b4fd589762b0b9329@syzkaller.appspotmail.com Tested-by: syzbot+e27b4fd589762b0b9329@syzkaller.appspotmail.com Signed-off-by: Anant Thazhemadam Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/dvb-usb/dibusb-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb/dibusb-common.c b/drivers/media/usb/dvb-usb/dibusb-common.c index fb1b4f2d5f9de..85b7838b3ede3 100644 --- a/drivers/media/usb/dvb-usb/dibusb-common.c +++ b/drivers/media/usb/dvb-usb/dibusb-common.c @@ -226,7 +226,7 @@ int dibusb_read_eeprom_byte(struct dvb_usb_device *d, u8 offs, u8 *val) u8 *buf; int rc; - buf = kmalloc(2, GFP_KERNEL); + buf = kzalloc(2, GFP_KERNEL); if (!buf) return -ENOMEM; -- 2.33.0