From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
stable@vger.kernel.org, czhong@redhat.com
Subject: Re: [PATCH] block: avoid to touch unloaded module instance when opening bdev
Date: Wed, 10 Nov 2021 14:02:28 +0100 [thread overview]
Message-ID: <20211110130228.GB25614@lst.de> (raw)
In-Reply-To: <20211110095511.294645-1-ming.lei@redhat.com>
The technical change looks good, but this comment not only has quite
a few of grammar issues, but also seems rather pointless:
> + /*
> + * New open() will be failed since disk becomes not alive, and old
> + * open() has either grabbed the module refcnt or been failed in
> + * case of deleting from module_exit(), so disk->fops->owner won't
> + * be unloaded if the disk is opened.
> + */
> mutex_lock(&disk->open_mutex);
> remove_inode_hash(disk->part0->bd_inode);
> blk_drop_partitions(disk);
> --
> 2.31.1
---end quoted
prev parent reply other threads:[~2021-11-10 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 9:55 [PATCH] block: avoid to touch unloaded module instance when opening bdev Ming Lei
2021-11-10 13:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110130228.GB25614@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=czhong@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox