From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3B7DC4321E for ; Tue, 16 Nov 2021 00:53:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFC9C61B3D for ; Tue, 16 Nov 2021 00:53:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359261AbhKPA4u (ORCPT ); Mon, 15 Nov 2021 19:56:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:44608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245677AbhKOTVA (ORCPT ); Mon, 15 Nov 2021 14:21:00 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id AA1A363578; Mon, 15 Nov 2021 18:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637001548; bh=KxrF9qoE5kZVi++j8rzgQeIsVxV07q20Pd1Lmu1DxSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zjgWPcIHY1D2F9Ocg8nrOFjJVCKc6wWfBXY0TKLRfSN2zpV+hPouj/YaDYi9kBlvn gMEEnTEl1BOYgKOgEGY0ekGl/i5cg0mo5GCnQU+7rzke9pm6wAPZgMPwrorBbEeyfw zD9YJrikso5CQ0n0ctpE9ymZy3ku2COETzHnA2WM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com, Rajat Asthana , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.15 231/917] media: mceusb: return without resubmitting URB in case of -EPROTO error. Date: Mon, 15 Nov 2021 17:55:26 +0100 Message-Id: <20211115165436.619510431@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211115165428.722074685@linuxfoundation.org> References: <20211115165428.722074685@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Rajat Asthana [ Upstream commit 476db72e521983ecb847e4013b263072bb1110fc ] Syzkaller reported a warning called "rcu detected stall in dummy_timer". The error seems to be an error in mceusb_dev_recv(). In the case of -EPROTO error, the routine immediately resubmits the URB. Instead it should return without resubmitting URB. Reported-by: syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com Signed-off-by: Rajat Asthana Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/rc/mceusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index e03dd1f0144f0..137a71954aabf 100644 --- a/drivers/media/rc/mceusb.c +++ b/drivers/media/rc/mceusb.c @@ -1386,6 +1386,7 @@ static void mceusb_dev_recv(struct urb *urb) case -ECONNRESET: case -ENOENT: case -EILSEQ: + case -EPROTO: case -ESHUTDOWN: usb_unlink_urb(urb); return; -- 2.33.0