From: "Marek Behún" <kabel@kernel.org>
To: <gregkh@linuxfoundation.org>
Cc: davem@davemloft.net, <stable@vger.kernel.org>
Subject: Re: FAILED: patch "[PATCH] net: dsa: mv88e6xxx: Save power by disabling SerDes" failed to apply to 5.15-stable tree
Date: Sat, 4 Dec 2021 11:57:19 +0100 [thread overview]
Message-ID: <20211204115719.3315663b@thinkpad> (raw)
In-Reply-To: <16386137159777@kroah.com>
In fact it was a series of 6 patches, but the 2nd was without fixes tag:
21635d9203e1cf2b73b67e9a86059a62f62a3563
8c3318b4874e2dee867f5ae8f6d38f78e044bf71 (without fixes tag)
7527d66260ac0c603c6baca5146748061fcddbd6 (didnt apply)
93fd8207bed80ce19aaf59932cbe1c03d418a37d
163000dbc772c1eae9bdfe7c8fe30155db1efd74
ede359d8843a2779d232ed30bc36089d4b5962e4
On Sat, 04 Dec 2021 11:28:35 +0100
<gregkh@linuxfoundation.org> wrote:
> The patch below does not apply to the 5.15-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.
>
> thanks,
>
> greg k-h
>
> ------------------ original commit in Linus's tree ------------------
>
> From 7527d66260ac0c603c6baca5146748061fcddbd6 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Marek=20Beh=C3=BAn?= <kabel@kernel.org>
> Date: Tue, 30 Nov 2021 18:01:48 +0100
> Subject: [PATCH] net: dsa: mv88e6xxx: Save power by disabling SerDes
> trasmitter and receiver
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Save power on 88E6393X by disabling SerDes receiver and transmitter
> after SerDes is SerDes is disabled.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Cc: stable@vger.kernel.org # de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family")
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c
> index 3a6244596a67..ceb63d7f1f97 100644
> --- a/drivers/net/dsa/mv88e6xxx/serdes.c
> +++ b/drivers/net/dsa/mv88e6xxx/serdes.c
> @@ -1271,6 +1271,28 @@ void mv88e6390_serdes_get_regs(struct mv88e6xxx_chip *chip, int port, void *_p)
> }
> }
>
> +static int mv88e6393x_serdes_power_lane(struct mv88e6xxx_chip *chip, int lane,
> + bool on)
> +{
> + u16 reg;
> + int err;
> +
> + err = mv88e6390_serdes_read(chip, lane, MDIO_MMD_PHYXS,
> + MV88E6393X_SERDES_CTRL1, ®);
> + if (err)
> + return err;
> +
> + if (on)
> + reg &= ~(MV88E6393X_SERDES_CTRL1_TX_PDOWN |
> + MV88E6393X_SERDES_CTRL1_RX_PDOWN);
> + else
> + reg |= MV88E6393X_SERDES_CTRL1_TX_PDOWN |
> + MV88E6393X_SERDES_CTRL1_RX_PDOWN;
> +
> + return mv88e6390_serdes_write(chip, lane, MDIO_MMD_PHYXS,
> + MV88E6393X_SERDES_CTRL1, reg);
> +}
> +
> static int mv88e6393x_serdes_erratum_4_6(struct mv88e6xxx_chip *chip, int lane)
> {
> u16 reg;
> @@ -1297,7 +1319,11 @@ static int mv88e6393x_serdes_erratum_4_6(struct mv88e6xxx_chip *chip, int lane)
> if (err)
> return err;
>
> - return mv88e6390_serdes_power_sgmii(chip, lane, false);
> + err = mv88e6390_serdes_power_sgmii(chip, lane, false);
> + if (err)
> + return err;
> +
> + return mv88e6393x_serdes_power_lane(chip, lane, false);
> }
>
> int mv88e6393x_serdes_setup_errata(struct mv88e6xxx_chip *chip)
> @@ -1362,17 +1388,29 @@ int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
> err = mv88e6393x_serdes_erratum_4_8(chip, lane);
> if (err)
> return err;
> +
> + err = mv88e6393x_serdes_power_lane(chip, lane, true);
> + if (err)
> + return err;
> }
>
> switch (cmode) {
> case MV88E6XXX_PORT_STS_CMODE_SGMII:
> case MV88E6XXX_PORT_STS_CMODE_1000BASEX:
> case MV88E6XXX_PORT_STS_CMODE_2500BASEX:
> - return mv88e6390_serdes_power_sgmii(chip, lane, on);
> + err = mv88e6390_serdes_power_sgmii(chip, lane, on);
> + break;
> case MV88E6393X_PORT_STS_CMODE_5GBASER:
> case MV88E6393X_PORT_STS_CMODE_10GBASER:
> - return mv88e6390_serdes_power_10g(chip, lane, on);
> + err = mv88e6390_serdes_power_10g(chip, lane, on);
> + break;
> }
>
> - return 0;
> + if (err)
> + return err;
> +
> + if (!on)
> + err = mv88e6393x_serdes_power_lane(chip, lane, false);
> +
> + return err;
> }
> diff --git a/drivers/net/dsa/mv88e6xxx/serdes.h b/drivers/net/dsa/mv88e6xxx/serdes.h
> index cbb3ba30caea..e9292c8beee4 100644
> --- a/drivers/net/dsa/mv88e6xxx/serdes.h
> +++ b/drivers/net/dsa/mv88e6xxx/serdes.h
> @@ -93,6 +93,9 @@
> #define MV88E6393X_SERDES_POC_PCS_MASK 0x0007
> #define MV88E6393X_SERDES_POC_RESET BIT(15)
> #define MV88E6393X_SERDES_POC_PDOWN BIT(5)
> +#define MV88E6393X_SERDES_CTRL1 0xf003
> +#define MV88E6393X_SERDES_CTRL1_TX_PDOWN BIT(9)
> +#define MV88E6393X_SERDES_CTRL1_RX_PDOWN BIT(8)
>
> #define MV88E6393X_ERRATA_4_8_REG 0xF074
> #define MV88E6393X_ERRATA_4_8_BIT BIT(14)
>
next prev parent reply other threads:[~2021-12-04 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 10:28 FAILED: patch "[PATCH] net: dsa: mv88e6xxx: Save power by disabling SerDes" failed to apply to 5.15-stable tree gregkh
2021-12-04 10:54 ` Marek Behún
2021-12-04 10:57 ` Marek Behún [this message]
2021-12-05 12:41 ` Greg KH
2021-12-05 12:49 ` Marek Behún
2021-12-05 12:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211204115719.3315663b@thinkpad \
--to=kabel@kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox