Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: stable@vger.kernel.org
Subject: [PATCH 5.10 1/8] perf inject: Fix itrace space allowed for new attributes
Date: Mon, 13 Dec 2021 17:45:41 +0200	[thread overview]
Message-ID: <20211213154548.122728-2-adrian.hunter@intel.com> (raw)
In-Reply-To: <20211213154548.122728-1-adrian.hunter@intel.com>

commit c29d9792607e67ed8a3f6e9db0d96836d885a8c5 upstream.

The space allowed for new attributes can be too small if existing header
information is large. That can happen, for example, if there are very
many CPUs, due to having an event ID per CPU per event being stored in the
header information.

Fix by adding the existing header.data_offset. Also increase the extra
space allowed to 8KiB and align to a 4KiB boundary for neatness.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lore.kernel.org/lkml/20211125071457.2066863-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
[Adrian: Backport to v5.10]
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 tools/perf/builtin-inject.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
index 5378a14e3836..8f1a99e2fcd7 100644
--- a/tools/perf/builtin-inject.c
+++ b/tools/perf/builtin-inject.c
@@ -752,7 +752,7 @@ static int __cmd_inject(struct perf_inject *inject)
 		inject->tool.ordered_events = true;
 		inject->tool.ordering_requires_timestamps = true;
 		/* Allow space in the header for new attributes */
-		output_data_offset = 4096;
+		output_data_offset = roundup(8192 + session->header.data_offset, 4096);
 		if (inject->strip)
 			strip_init(inject);
 	}
-- 
2.25.1


  reply	other threads:[~2021-12-13 15:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 15:45 [PATCH 5.10 0/8] perf intel_pt: Fixes for v5.10 Adrian Hunter
2021-12-13 15:45 ` Adrian Hunter [this message]
2021-12-13 15:45 ` [PATCH 5.10 2/8] perf intel-pt: Fix some PGE (packet generation enable/control flow packets) usage Adrian Hunter
2021-12-13 15:45 ` [PATCH 5.10 3/8] perf intel-pt: Fix sync state when a PSB (synchronization) packet is found Adrian Hunter
2021-12-13 15:45 ` [PATCH 5.10 4/8] perf intel-pt: Fix intel_pt_fup_event() assumptions about setting state type Adrian Hunter
2021-12-13 15:45 ` [PATCH 5.10 5/8] perf intel-pt: Fix state setting when receiving overflow (OVF) packet Adrian Hunter
2021-12-13 15:45 ` [PATCH 5.10 6/8] perf intel-pt: Fix next 'err' value, walking trace Adrian Hunter
2021-12-13 15:45 ` [PATCH 5.10 7/8] perf intel-pt: Fix missing 'instruction' events with 'q' option Adrian Hunter
2021-12-13 15:45 ` [PATCH 5.10 8/8] perf intel-pt: Fix error timestamp setting on the decoder error path Adrian Hunter
2021-12-15 14:00 ` [PATCH 5.10 0/8] perf intel_pt: Fixes for v5.10 Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211213154548.122728-2-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox