Re: [PATCH] platform/x86: intel_pmc_core: fix memleak on registration failure

Greg Kroah-Hartman
2021-12-22T11:06:02Z

On Wed, Dec 22, 2021 at 11:50:23AM +0100, Johan Hovold wrote:
> In case device registration fails during module initialisation, the
> platform device structure needs to be freed using platform_device_put()
> to properly free all resources (e.g. the device name).
>
> Fixes: 938835aa903a ("platform/x86: intel_pmc_core: do not create a static struct device")
> Cc: stable@vger.kernel.org # 5.9
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/platform/x86/intel/pmc/pltdrv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/pmc/pltdrv.c b/drivers/platform/x86/intel/pmc/pltdrv.c
> index 73797680b895..15ca8afdd973 100644
> --- a/drivers/platform/x86/intel/pmc/pltdrv.c
> +++ b/drivers/platform/x86/intel/pmc/pltdrv.c
> @@ -65,7 +65,7 @@ static int __init pmc_core_platform_init(void)
>
> retval = platform_device_register(pmc_core_device);
> if (retval)
> - kfree(pmc_core_device);
> + platform_device_put(pmc_core_device);
>
> return retval;
> }
> --
> 2.32.0
>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>