stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Changcheng Deng <deng.changcheng@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>, Abel Vesa <abel.vesa@nxp.com>,
	Sasha Levin <sashal@kernel.org>,
	mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org,
	linux-clk@vger.kernel.org, linux-imx@nxp.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH AUTOSEL 5.15 01/44] clk: imx: Use div64_ul instead of do_div
Date: Mon, 17 Jan 2022 12:00:44 -0500	[thread overview]
Message-ID: <20220117170127.1471115-1-sashal@kernel.org> (raw)

From: Changcheng Deng <deng.changcheng@zte.com.cn>

[ Upstream commit c1b6ad9a902539f9c037b6b3c35cb134c5724022 ]

do_div() does a 64-by-32 division. Here the divisor is an unsigned long
which on some platforms is 64 bit wide. So use div64_ul instead of do_div
to avoid a possible truncation.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
Link: https://lore.kernel.org/r/20211118080634.165275-1-deng.changcheng@zte.com.cn
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/clk/imx/clk-pllv3.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
index 20ee9611ba6e3..eea32f87c60aa 100644
--- a/drivers/clk/imx/clk-pllv3.c
+++ b/drivers/clk/imx/clk-pllv3.c
@@ -247,7 +247,7 @@ static long clk_pllv3_av_round_rate(struct clk_hw *hw, unsigned long rate,
 	div = rate / parent_rate;
 	temp64 = (u64) (rate - div * parent_rate);
 	temp64 *= mfd;
-	do_div(temp64, parent_rate);
+	temp64 = div64_ul(temp64, parent_rate);
 	mfn = temp64;
 
 	temp64 = (u64)parent_rate;
@@ -277,7 +277,7 @@ static int clk_pllv3_av_set_rate(struct clk_hw *hw, unsigned long rate,
 	div = rate / parent_rate;
 	temp64 = (u64) (rate - div * parent_rate);
 	temp64 *= mfd;
-	do_div(temp64, parent_rate);
+	temp64 = div64_ul(temp64, parent_rate);
 	mfn = temp64;
 
 	val = readl_relaxed(pll->base);
@@ -334,7 +334,7 @@ static struct clk_pllv3_vf610_mf clk_pllv3_vf610_rate_to_mf(
 		/* rate = parent_rate * (mfi + mfn/mfd) */
 		temp64 = rate - parent_rate * mf.mfi;
 		temp64 *= mf.mfd;
-		do_div(temp64, parent_rate);
+		temp64 = div64_ul(temp64, parent_rate);
 		mf.mfn = temp64;
 	}
 
-- 
2.34.1


             reply	other threads:[~2022-01-17 17:02 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 17:00 Sasha Levin [this message]
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 02/44] powerpc/6xx: add missing of_node_put Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 03/44] powerpc/powernv: " Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 04/44] powerpc/cell: " Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 05/44] powerpc/btext: " Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 06/44] powerpc/watchdog: Fix missed watchdog reset due to memory ordering race Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 07/44] ASoC: imx-hdmi: add put_device() after of_find_device_by_node() Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 08/44] i2c: i801: Don't silently correct invalid transfer size Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 09/44] powerpc/smp: Move setup_profiling_timer() under CONFIG_PROFILING Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 10/44] i2c: mpc: Correct I2C reset procedure Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 11/44] clk: meson: gxbb: Fix the SDM_EN bit for MPLL0 on GXBB Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 12/44] powerpc/powermac: Add missing lockdep_register_key() Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 13/44] KVM: PPC: Book3S: Suppress warnings when allocating too big memory slots Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 14/44] KVM: PPC: Book3S: Suppress failed alloc warning in H_COPY_TOFROM_GUEST Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 15/44] w1: Misuse of get_user()/put_user() reported by sparse Sasha Levin
2022-01-17 17:00 ` [PATCH AUTOSEL 5.15 16/44] nvmem: core: set size for sysfs bin file Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 17/44] dm: fix alloc_dax error handling in alloc_dev Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 18/44] interconnect: qcom: rpm: Prevent integer overflow in rate Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 19/44] scsi: ufs: Fix a kernel crash during shutdown Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 20/44] scsi: lpfc: Fix leaked lpfc_dmabuf mbox allocations with NPIV Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 21/44] scsi: lpfc: Trigger SLI4 firmware dump before doing driver cleanup Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 22/44] ALSA: seq: Set upper limit of processed events Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 23/44] MIPS: Loongson64: Use three arguments for slti Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 24/44] powerpc/40x: Map 32Mbytes of memory at startup Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 25/44] selftests/powerpc/spectre_v2: Return skip code when miss_percent is high Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 26/44] powerpc: handle kdump appropriately with crash_kexec_post_notifiers option Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 27/44] powerpc/fadump: Fix inaccurate CPU state info in vmcore generated with panic Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 28/44] udf: Fix error handling in udf_new_inode() Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 29/44] MIPS: OCTEON: add put_device() after of_find_device_by_node() Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 30/44] irqchip/gic-v4: Disable redistributors' view of the VPE table at boot time Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 31/44] i2c: designware-pci: Fix to change data types of hcnt and lcnt parameters Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 32/44] PCI/MSI: Decouple MSI[-X] disable from pcim_release() Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 33/44] selftests/powerpc: Add a test of sigreturning to the kernel Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 34/44] MIPS: Octeon: Fix build errors using clang Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 35/44] scsi: sr: Don't use GFP_DMA Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 36/44] scsi: mpi3mr: Fixes around reply request queues Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 37/44] ASoC: mediatek: mt8192-mt6359: fix device_node leak Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 38/44] phy: phy-mtk-tphy: add support efuse setting Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 39/44] ASoC: mediatek: mt8173: fix device_node leak Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 40/44] ASoC: mediatek: mt8183: " Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 41/44] habanalabs: skip read fw errors if dynamic descriptor invalid Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 42/44] phy: mediatek: Fix missing check in mtk_mipi_tx_probe Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 43/44] mailbox: change mailbox-mpfs compatible string Sasha Levin
2022-01-17 17:01 ` [PATCH AUTOSEL 5.15 44/44] leds: leds-fsg: Drop FSG3 LED driver Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220117170127.1471115-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=abel.vesa@nxp.com \
    --cc=deng.changcheng@zte.com.cn \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).