From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
Fabiano Rosas <farosas@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Sasha Levin <sashal@kernel.org>,
npiggin@gmail.com, paulus@ozlabs.org,
ravi.bangoria@linux.ibm.com, bharata@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH AUTOSEL 5.4 12/21] KVM: PPC: Book3S: Suppress failed alloc warning in H_COPY_TOFROM_GUEST
Date: Mon, 17 Jan 2022 12:04:44 -0500 [thread overview]
Message-ID: <20220117170454.1472347-12-sashal@kernel.org> (raw)
In-Reply-To: <20220117170454.1472347-1-sashal@kernel.org>
From: Alexey Kardashevskiy <aik@ozlabs.ru>
[ Upstream commit 792020907b11c6f9246c21977cab3bad985ae4b6 ]
H_COPY_TOFROM_GUEST is an hcall for an upper level VM to access its nested
VMs memory. The userspace can trigger WARN_ON_ONCE(!(gfp & __GFP_NOWARN))
in __alloc_pages() by constructing a tiny VM which only does
H_COPY_TOFROM_GUEST with a too big GPR9 (number of bytes to copy).
This silences the warning by adding __GFP_NOWARN.
Spotted by syzkaller.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Fabiano Rosas <farosas@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210901084550.1658699-1-aik@ozlabs.ru
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/powerpc/kvm/book3s_hv_nested.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_hv_nested.c b/arch/powerpc/kvm/book3s_hv_nested.c
index 9906d203d9d39..613d24b707abe 100644
--- a/arch/powerpc/kvm/book3s_hv_nested.c
+++ b/arch/powerpc/kvm/book3s_hv_nested.c
@@ -510,7 +510,7 @@ long kvmhv_copy_tofrom_guest_nested(struct kvm_vcpu *vcpu)
if (eaddr & (0xFFFUL << 52))
return H_PARAMETER;
- buf = kzalloc(n, GFP_KERNEL);
+ buf = kzalloc(n, GFP_KERNEL | __GFP_NOWARN);
if (!buf)
return H_NO_MEM;
--
2.34.1
next prev parent reply other threads:[~2022-01-17 17:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 17:04 [PATCH AUTOSEL 5.4 01/21] clk: imx: Use div64_ul instead of do_div Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 02/21] powerpc/6xx: add missing of_node_put Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 03/21] powerpc/powernv: " Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 04/21] powerpc/cell: " Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 05/21] powerpc/btext: " Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 06/21] powerpc/watchdog: Fix missed watchdog reset due to memory ordering race Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 07/21] i2c: i801: Don't silently correct invalid transfer size Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 08/21] powerpc/smp: Move setup_profiling_timer() under CONFIG_PROFILING Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 09/21] i2c: mpc: Correct I2C reset procedure Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 10/21] clk: meson: gxbb: Fix the SDM_EN bit for MPLL0 on GXBB Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 11/21] powerpc/powermac: Add missing lockdep_register_key() Sasha Levin
2022-01-17 17:04 ` Sasha Levin [this message]
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 13/21] w1: Misuse of get_user()/put_user() reported by sparse Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 14/21] scsi: lpfc: Trigger SLI4 firmware dump before doing driver cleanup Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 15/21] ALSA: seq: Set upper limit of processed events Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 16/21] powerpc: handle kdump appropriately with crash_kexec_post_notifiers option Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 17/21] MIPS: OCTEON: add put_device() after of_find_device_by_node() Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 18/21] i2c: designware-pci: Fix to change data types of hcnt and lcnt parameters Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 19/21] MIPS: Octeon: Fix build errors using clang Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 20/21] scsi: sr: Don't use GFP_DMA Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 21/21] ASoC: mediatek: mt8173: fix device_node leak Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117170454.1472347-12-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.ibm.com \
--cc=farosas@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@ozlabs.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).