From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>, Baoquan He <bhe@redhat.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Sasha Levin <sashal@kernel.org>,
jejb@linux.ibm.com, linux-scsi@vger.kernel.org
Subject: [PATCH AUTOSEL 5.4 20/21] scsi: sr: Don't use GFP_DMA
Date: Mon, 17 Jan 2022 12:04:52 -0500 [thread overview]
Message-ID: <20220117170454.1472347-20-sashal@kernel.org> (raw)
In-Reply-To: <20220117170454.1472347-1-sashal@kernel.org>
From: Christoph Hellwig <hch@lst.de>
[ Upstream commit d94d94969a4ba07a43d62429c60372320519c391 ]
The allocated buffers are used as a command payload, for which the block
layer and/or DMA API do the proper bounce buffering if needed.
Link: https://lore.kernel.org/r/20211222090842.920724-1-hch@lst.de
Reported-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/scsi/sr.c | 2 +-
drivers/scsi/sr_vendor.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index 279dea628620d..310da62cda263 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -887,7 +887,7 @@ static void get_capabilities(struct scsi_cd *cd)
/* allocate transfer buffer */
- buffer = kmalloc(512, GFP_KERNEL | GFP_DMA);
+ buffer = kmalloc(512, GFP_KERNEL);
if (!buffer) {
sr_printk(KERN_ERR, cd, "out of memory.\n");
return;
diff --git a/drivers/scsi/sr_vendor.c b/drivers/scsi/sr_vendor.c
index b9db2ec6d0361..996bccadd3866 100644
--- a/drivers/scsi/sr_vendor.c
+++ b/drivers/scsi/sr_vendor.c
@@ -113,7 +113,7 @@ int sr_set_blocklength(Scsi_CD *cd, int blocklength)
if (cd->vendor == VENDOR_TOSHIBA)
density = (blocklength > 2048) ? 0x81 : 0x83;
- buffer = kmalloc(512, GFP_KERNEL | GFP_DMA);
+ buffer = kmalloc(512, GFP_KERNEL);
if (!buffer)
return -ENOMEM;
@@ -161,7 +161,7 @@ int sr_cd_check(struct cdrom_device_info *cdi)
if (cd->cdi.mask & CDC_MULTI_SESSION)
return 0;
- buffer = kmalloc(512, GFP_KERNEL | GFP_DMA);
+ buffer = kmalloc(512, GFP_KERNEL);
if (!buffer)
return -ENOMEM;
--
2.34.1
next prev parent reply other threads:[~2022-01-17 17:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 17:04 [PATCH AUTOSEL 5.4 01/21] clk: imx: Use div64_ul instead of do_div Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 02/21] powerpc/6xx: add missing of_node_put Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 03/21] powerpc/powernv: " Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 04/21] powerpc/cell: " Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 05/21] powerpc/btext: " Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 06/21] powerpc/watchdog: Fix missed watchdog reset due to memory ordering race Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 07/21] i2c: i801: Don't silently correct invalid transfer size Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 08/21] powerpc/smp: Move setup_profiling_timer() under CONFIG_PROFILING Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 09/21] i2c: mpc: Correct I2C reset procedure Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 10/21] clk: meson: gxbb: Fix the SDM_EN bit for MPLL0 on GXBB Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 11/21] powerpc/powermac: Add missing lockdep_register_key() Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 12/21] KVM: PPC: Book3S: Suppress failed alloc warning in H_COPY_TOFROM_GUEST Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 13/21] w1: Misuse of get_user()/put_user() reported by sparse Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 14/21] scsi: lpfc: Trigger SLI4 firmware dump before doing driver cleanup Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 15/21] ALSA: seq: Set upper limit of processed events Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 16/21] powerpc: handle kdump appropriately with crash_kexec_post_notifiers option Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 17/21] MIPS: OCTEON: add put_device() after of_find_device_by_node() Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 18/21] i2c: designware-pci: Fix to change data types of hcnt and lcnt parameters Sasha Levin
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 19/21] MIPS: Octeon: Fix build errors using clang Sasha Levin
2022-01-17 17:04 ` Sasha Levin [this message]
2022-01-17 17:04 ` [PATCH AUTOSEL 5.4 21/21] ASoC: mediatek: mt8173: fix device_node leak Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117170454.1472347-20-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=bhe@redhat.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).