From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6A1AC433EF for ; Mon, 17 Jan 2022 17:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243078AbiAQRLs (ORCPT ); Mon, 17 Jan 2022 12:11:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243718AbiAQRKO (ORCPT ); Mon, 17 Jan 2022 12:10:14 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07430C061A80; Mon, 17 Jan 2022 09:06:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A3131B81147; Mon, 17 Jan 2022 17:06:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0FFDC36AE3; Mon, 17 Jan 2022 17:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642439163; bh=lonuAKS53DUKY+ol5S4xBe1LsE3sXOcVFIl4cO81vTE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CvoOTur+iy3Wppn2rk4gGryz/53BdTiZDtF8RmnL5/UhAzsixObyHUIvtgxC/hSpw rLVS+xwOsUiaZ6TWlOUTFvZMEKxpBE/AUrYYDWv4ZW7sVtQ4/2AGw0FpH5PnC6GUxs 2wGHVNypRJKGY9oVBQPCnYzkncpgcREp2x/u4GlZ1pkTYGzGMK3/ebDJ3a9RK+EaYq 1McLepLqTXczbLX+qwNs8jNuloDC9QOqrF+3n6PRSCYHAMhSrNQVmwApnpNnD4SzLM odrOiVSjNV83+r/yYgrbHXknME9cMXdZBDvs07aK2lNvkiC8J9P9/jZagFzPQkF1Om +8VcFGOL2Rxkg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Julia Lawall , Michael Ellerman , Sasha Levin , nick.child@ibm.com, linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 4.19 05/17] powerpc/btext: add missing of_node_put Date: Mon, 17 Jan 2022 12:05:39 -0500 Message-Id: <20220117170551.1472640-5-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220117170551.1472640-1-sashal@kernel.org> References: <20220117170551.1472640-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Julia Lawall [ Upstream commit a1d2b210ffa52d60acabbf7b6af3ef7e1e69cda0 ] for_each_node_by_type performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ local idexpression n; expression e; @@ for_each_node_by_type(n,...) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? break; ) ... } ... when != n // Signed-off-by: Julia Lawall Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/1448051604-25256-6-git-send-email-Julia.Lawall@lip6.fr Signed-off-by: Sasha Levin --- arch/powerpc/kernel/btext.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c index b2072d5bbf2bb..a046504d8bfaf 100644 --- a/arch/powerpc/kernel/btext.c +++ b/arch/powerpc/kernel/btext.c @@ -258,8 +258,10 @@ int __init btext_find_display(int allow_nonstdout) rc = btext_initialize(np); printk("result: %d\n", rc); } - if (rc == 0) + if (rc == 0) { + of_node_put(np); break; + } } return rc; } -- 2.34.1