Re: [PATCH 5.4 000/320] 5.4.174-rc1 review

Greg Kroah-Hartman
2022-01-25T15:53:50Z

On Tue, Jan 25, 2022 at 03:48:31PM +0100, Helge Deller wrote:
> * Naresh Kamboju <naresh.kamboju@linaro.org>:
> > > On 1/24/22 12:39, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 5.4.174 release.
> > > > There are 320 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Wed, 26 Jan 2022 18:39:11 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.174-rc1.gz
> > > > or in the git tree and branch at:
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> >
> > [...]
> >
> > This is from PA-RISC with gcc-8, gcc-9, gcc-10, gcc-11:
> >
> > > /builds/linux/drivers/parisc/sba_iommu.c: In function 'sba_io_pdir_entry':
> > > /builds/linux/arch/parisc/include/asm/special_insns.h:11:3: error: expected ':' or ')' before 'ASM_EXCEPTIONTABLE_ENTRY'
> > > ASM_EXCEPTIONTABLE_ENTRY(8b, 9b) \
> > > ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Bisection of the latter points to "parisc: Fix lpa and lpa_user defines".
> >
> > commit 73c8c7ecdc141c20c9dbc8f3ec176e233942b0d9
> > parisc: Fix lpa and lpa_user defines
> > [ commit db19c6f1a2a353cc8dec35b4789733a3cf6e2838 upstream ]
>
> Naresh, thanks for noticing and bisecting!
>
> The problem is, that in v5.4.x we are missing to include a header file
> which is probably already indirectly included in the other Linux versions.
>
> Greg, can you either drop this commit:
>
> commit 73c8c7ecdc141c20c9dbc8f3ec176e233942b0d9
> parisc: Fix lpa and lpa_user defines
>
> or simply add the patch below to the commit?
>
> Either solution which is easier for you is ok.

I've just dropped it now, thanks.

greg k-h