From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE9BBC433EF for ; Sat, 29 Jan 2022 12:04:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243759AbiA2MEs (ORCPT ); Sat, 29 Jan 2022 07:04:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243421AbiA2MEr (ORCPT ); Sat, 29 Jan 2022 07:04:47 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAE95C061714; Sat, 29 Jan 2022 04:04:47 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1nDmTE-0002d5-1M; Sat, 29 Jan 2022 13:04:44 +0100 Date: Sat, 29 Jan 2022 13:04:44 +0100 From: Florian Westphal To: Greg KH Cc: Florian Westphal , stable@vger.kernel.org, netfilter-devel@vger.kernel.org, Pablo Neira Ayuso , Steffen Weinreich Subject: Re: [PATCH 4.19.y] netfilter: nft_payload: do not update layer 4 checksum when mangling fragments Message-ID: <20220129120444.GJ25922@breakpoint.cc> References: <20220128113821.7009-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Greg KH wrote: > On Fri, Jan 28, 2022 at 12:38:21PM +0100, Florian Westphal wrote: > > From: Pablo Neira Ayuso > > > > commit 4e1860a3863707e8177329c006d10f9e37e097a8 upstream. > > > > IP fragments do not come with the transport header, hence skip bogus > > layer 4 checksum updates. > > > > Fixes: 1814096980bb ("netfilter: nft_payload: layer 4 checksum adjustment for pseudoheader fields") > > Reported-and-tested-by: Steffen Weinreich > > Signed-off-by: Pablo Neira Ayuso > > Signed-off-by: Florian Westphal > > --- > > This is already in the 5.y branches but 4.19 needs a minor > > tweak as ->fragoff member resides in xt sub-struct. > > I don't see this commit in the 5.10 or 5.4 branches, am I missing > something? Oh, indeed. Can you place this patch in 5.4 and 5.10 too? Releases >= v5.14 should be covered given upstream commit works as-is on those. Thanks, Florian