From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC36C433FE for ; Thu, 3 Feb 2022 20:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355565AbiBCUiF (ORCPT ); Thu, 3 Feb 2022 15:38:05 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:42168 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355588AbiBCUgD (ORCPT ); Thu, 3 Feb 2022 15:36:03 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E3E56009B; Thu, 3 Feb 2022 20:36:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C333DC340E8; Thu, 3 Feb 2022 20:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643920562; bh=/T57QsHEXzWRyz9ngAgfSuXzq9rnlQ9xNPWF7J/q3zk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZVQrQurxo6xkuE5K1R67cYpF93zNBIFeUOuPwb+SO989o/2o/YJOxmYoIhVBC4Vxq OhRWo1PAlkqOE5PTSyeRq/6K+frg9Byvhl2wj4gca+oMpF2i3X3tmoIAL0meDugBXD ZjA1zVf6eD3z3yDjzRdz+5e6QmLqRTdH656/GlAYnMfsnsThRqNQBAy2EAik3NL1DC tOhQZJOrqTYJNrFwmzLG4lsa4JTVUYcqJ0C30ePJVj+39Y6jUwBVX1iXLorjIBTV+S UlfErW60tcBVxVDH9clMCTYAHDt9kZJCfZuRBzK+458uvR1PYk1HVGq1OmqL9jFTfR O+5sovS3936DQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: ZouMingzhe , Mike Christie , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 09/15] scsi: target: iscsi: Make sure the np under each tpg is unique Date: Thu, 3 Feb 2022 15:35:39 -0500 Message-Id: <20220203203545.3879-9-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220203203545.3879-1-sashal@kernel.org> References: <20220203203545.3879-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: ZouMingzhe [ Upstream commit a861790afaa8b6369eee8a88c5d5d73f5799c0c6 ] iscsit_tpg_check_network_portal() has nested for_each loops and is supposed to return true when a match is found. However, the tpg loop will still continue after existing the tpg_np loop. If this tpg_np is not the last the match value will be changed. Break the outer loop after finding a match and make sure the np under each tpg is unique. Link: https://lore.kernel.org/r/20220111054742.19582-1-mingzhe.zou@easystack.cn Signed-off-by: ZouMingzhe Reviewed-by: Mike Christie Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/iscsi/iscsi_target_tpg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/target/iscsi/iscsi_target_tpg.c b/drivers/target/iscsi/iscsi_target_tpg.c index 8075f60fd02c3..2d5cf1714ae05 100644 --- a/drivers/target/iscsi/iscsi_target_tpg.c +++ b/drivers/target/iscsi/iscsi_target_tpg.c @@ -443,6 +443,9 @@ static bool iscsit_tpg_check_network_portal( break; } spin_unlock(&tpg->tpg_np_lock); + + if (match) + break; } spin_unlock(&tiqn->tiqn_tpg_lock); -- 2.34.1