From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org,
Janis Schoetterl-Glausch <scgl@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>
Subject: [PATCH 5.16 3/5] KVM: s390: Return error on SIDA memop on normal guest
Date: Wed, 9 Feb 2022 20:14:35 +0100 [thread overview]
Message-ID: <20220209191250.009221364@linuxfoundation.org> (raw)
In-Reply-To: <20220209191249.887150036@linuxfoundation.org>
From: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
commit 2c212e1baedcd782b2535a3f86bc491977677c0e upstream.
Refuse SIDA memops on guests which are not protected.
For normal guests, the secure instruction data address designation,
which determines the location we access, is not under control of KVM.
Fixes: 19e122776886 (KVM: S390: protvirt: Introduce instruction data area bounce buffer)
Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
Cc: stable@vger.kernel.org
Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
arch/s390/kvm/kvm-s390.c | 2 ++
1 file changed, 2 insertions(+)
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -4711,6 +4711,8 @@ static long kvm_s390_guest_sida_op(struc
return -EINVAL;
if (mop->size + mop->sida_offset > sida_size(vcpu->arch.sie_block))
return -E2BIG;
+ if (!kvm_s390_pv_cpu_is_protected(vcpu))
+ return -EINVAL;
switch (mop->op) {
case KVM_S390_MEMOP_SIDA_READ:
next prev parent reply other threads:[~2022-02-09 19:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 19:14 [PATCH 5.16 0/5] 5.16.9-rc1 review Greg Kroah-Hartman
2022-02-09 19:14 ` [PATCH 5.16 1/5] ata: libata-core: Fix ata_dev_config_cpr() Greg Kroah-Hartman
2022-02-09 19:14 ` [PATCH 5.16 2/5] moxart: fix potential use-after-free on remove path Greg Kroah-Hartman
2022-02-09 19:14 ` Greg Kroah-Hartman [this message]
2022-02-09 19:14 ` [PATCH 5.16 4/5] ksmbd: fix SMB 3.11 posix extension mount failure Greg Kroah-Hartman
2022-02-09 19:14 ` [PATCH 5.16 5/5] crypto: api - Move cryptomgr soft dependency into algapi Greg Kroah-Hartman
2022-02-09 22:48 ` [PATCH 5.16 0/5] 5.16.9-rc1 review Fox Chen
2022-02-10 0:57 ` Shuah Khan
2022-02-10 8:34 ` Jon Hunter
2022-02-10 10:56 ` Naresh Kamboju
2022-02-10 12:17 ` Scott Bruce
2022-02-10 14:44 ` Jeffrin Thalakkottoor
2022-02-10 15:54 ` Ron Economos
2022-02-10 18:49 ` Florian Fainelli
2022-02-10 21:02 ` Guenter Roeck
2022-02-11 6:13 ` Slade Watkins
2022-02-11 7:39 ` Bagas Sanjaya
2022-02-11 8:17 ` Rudi Heitbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209191250.009221364@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=scgl@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).