From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E003BC433F5 for ; Mon, 7 Mar 2022 10:03:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236941AbiCGKEb (ORCPT ); Mon, 7 Mar 2022 05:04:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240328AbiCGKA5 (ORCPT ); Mon, 7 Mar 2022 05:00:57 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D2955DE65; Mon, 7 Mar 2022 01:47:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B9C960FB3; Mon, 7 Mar 2022 09:47:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EC90C340E9; Mon, 7 Mar 2022 09:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646646447; bh=Tnx6U9YC1Pu0Qjrz/5h6IdvKiHowjP2ehmNNPaZpqeE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q+rWzz4AhsP59oGDv5oYzJOqeNRK38a/qOwy9Xq4xhYcjCQ+BMfsn46nD2xzuCIyV 1D72wcACMil6iumXZ3Z2cD8Bko0FfvxmD6my28SUD40z766cqL4tIpZiJ5XqpcJnbj 3SjS++fsvjXNcCcKwL2C8ndTW7LIAac4eudo0ywc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Konrad Jankowski , Tony Nguyen Subject: [PATCH 5.15 245/262] iavf: missing unlocks in iavf_watchdog_task() Date: Mon, 7 Mar 2022 10:19:49 +0100 Message-Id: <20220307091710.437712940@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307091702.378509770@linuxfoundation.org> References: <20220307091702.378509770@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter commit bc2f39a6252ee40d9bfc2743d4437d420aec5f6e upstream. This code was re-organized and there some unlocks missing now. Fixes: 898ef1cb1cb2 ("iavf: Combine init and watchdog state machines") Signed-off-by: Dan Carpenter Tested-by: Konrad Jankowski Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -2071,6 +2071,7 @@ static void iavf_watchdog_task(struct wo } adapter->aq_required = 0; adapter->current_op = VIRTCHNL_OP_UNKNOWN; + mutex_unlock(&adapter->crit_lock); queue_delayed_work(iavf_wq, &adapter->watchdog_task, msecs_to_jiffies(10)); @@ -2101,9 +2102,8 @@ static void iavf_watchdog_task(struct wo iavf_detect_recover_hung(&adapter->vsi); break; case __IAVF_REMOVE: - mutex_unlock(&adapter->crit_lock); - return; default: + mutex_unlock(&adapter->crit_lock); return; }