From: Xiaomeng Tong <xiam0nd.tong@gmail.com>
To: svens@linux.ibm.com
Cc: agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
dsterba@suse.com, elder@linaro.org, gor@linux.ibm.com,
gregkh@linuxfoundation.org, hca@linux.ibm.com,
jcmvbkbc@gmail.com, jirislaby@kernel.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
stable@vger.kernel.org, xiam0nd.tong@gmail.com
Subject: Re: [PATCH v2] char: tty3270: fix a missing check on list iterator
Date: Mon, 28 Mar 2022 17:38:31 +0800 [thread overview]
Message-ID: <20220328093831.28087-1-xiam0nd.tong@gmail.com> (raw)
In-Reply-To: <yt9dczi6cvln.fsf@linux.ibm.com>
> I should have written that in my first reply, but s == NULL means
> the given line number couldn't be found in the list of lines. This is
> a serious error and should be warned about. So maybe something like:
>
> if (WARN_ON(!s))
> return;
>
> But allocating a new empty line in that case is certainly wrong.
Thank you, i have resend a v3 patch as you suggested.
--
Xiaomeng Tong
prev parent reply other threads:[~2022-03-28 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 7:05 [PATCH v2] char: tty3270: fix a missing check on list iterator Xiaomeng Tong
2022-03-28 8:47 ` Sven Schnelle
2022-03-28 9:38 ` Xiaomeng Tong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328093831.28087-1-xiam0nd.tong@gmail.com \
--to=xiam0nd.tong@gmail.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=dsterba@suse.com \
--cc=elder@linaro.org \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox