From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>,
kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Marc Zyngier <maz@kernel.org>, Sasha Levin <sashal@kernel.org>,
tglx@linutronix.de
Subject: [PATCH AUTOSEL 5.15 17/29] irqchip/nvic: Release nvic_base upon failure
Date: Mon, 28 Mar 2022 07:21:19 -0400 [thread overview]
Message-ID: <20220328112132.1555683-17-sashal@kernel.org> (raw)
In-Reply-To: <20220328112132.1555683-1-sashal@kernel.org>
From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
[ Upstream commit e414c25e3399b2b3d7337dc47abccab5c71b7c8f ]
smatch warning was reported as below ->
smatch warnings:
drivers/irqchip/irq-nvic.c:131 nvic_of_init()
warn: 'nvic_base' not released on lines: 97.
Release nvic_base upon failure.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220218163303.33344-1-jrdr.linux@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/irqchip/irq-nvic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
index 599bb6fc5f0a..47b3b165479e 100644
--- a/drivers/irqchip/irq-nvic.c
+++ b/drivers/irqchip/irq-nvic.c
@@ -92,6 +92,7 @@ static int __init nvic_of_init(struct device_node *node,
if (!nvic_irq_domain) {
pr_warn("Failed to allocate irq domain\n");
+ iounmap(nvic_base);
return -ENOMEM;
}
@@ -101,6 +102,7 @@ static int __init nvic_of_init(struct device_node *node,
if (ret) {
pr_warn("Failed to allocate irq chips\n");
irq_domain_remove(nvic_irq_domain);
+ iounmap(nvic_base);
return ret;
}
--
2.34.1
next prev parent reply other threads:[~2022-03-28 11:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 11:21 [PATCH AUTOSEL 5.15 01/29] LSM: general protection fault in legacy_parse_param Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 02/29] regulator: rpi-panel: Handle I2C errors/timing to the Atmel Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 03/29] crypto: hisilicon/qm - cleanup warning in qm_vf_read_qos Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 04/29] gcc-plugins/stackleak: Exactly match strings instead of prefixes Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 05/29] pinctrl: npcm: Fix broken references to chip->parent_device Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 06/29] rcu: Mark writes to the rcu_segcblist structure's ->flags field Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 07/29] block/bfq_wf2q: correct weight to ioprio Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 08/29] crypto: xts - Add softdep on ecb Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 09/29] crypto: hisilicon/sec - not need to enable sm4 extra mode at HW V3 Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 10/29] block, bfq: don't move oom_bfqq Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 11/29] selinux: use correct type for context length Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 12/29] arm64: module: remove (NOLOAD) from linker script Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 13/29] selinux: allow FIOCLEX and FIONCLEX with policy capability Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 14/29] loop: use sysfs_emit() in the sysfs xxx show() Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 15/29] Fix incorrect type in assignment of ipv6 port for audit Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 16/29] irqchip/qcom-pdc: Fix broken locking Sasha Levin
2022-03-28 11:21 ` Sasha Levin [this message]
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 18/29] fs/binfmt_elf: Fix AT_PHDR for unusual ELF files Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 19/29] signal, x86: Delay calling signals in atomic on RT enabled kernels Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 20/29] bfq: fix use-after-free in bfq_dispatch_request Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 21/29] ACPICA: Avoid walking the ACPI Namespace if it is not there Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 22/29] lib/raid6/test/Makefile: Use $(pound) instead of \# for Make 4.3 Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 23/29] Revert "Revert "block, bfq: honor already-setup queue merges"" Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 24/29] ACPI/APEI: Limit printable size of BERT table data Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 25/29] PM: core: keep irq flags in device_pm_check_callbacks() Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 26/29] parisc: Fix handling off probe non-access faults Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 27/29] nvme-tcp: lockdep: annotate in-kernel sockets Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 28/29] spi: tegra20: Use of_device_get_match_data() Sasha Levin
2022-03-28 11:21 ` [PATCH AUTOSEL 5.15 29/29] Revert "ACPI: Pass the same capabilities to the _OSC regardless of the query flag" Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328112132.1555683-17-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maz@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox