From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>,
kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Marc Zyngier <maz@kernel.org>, Sasha Levin <sashal@kernel.org>,
tglx@linutronix.de
Subject: [PATCH AUTOSEL 5.10 11/21] irqchip/nvic: Release nvic_base upon failure
Date: Mon, 28 Mar 2022 07:22:44 -0400 [thread overview]
Message-ID: <20220328112254.1556286-11-sashal@kernel.org> (raw)
In-Reply-To: <20220328112254.1556286-1-sashal@kernel.org>
From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
[ Upstream commit e414c25e3399b2b3d7337dc47abccab5c71b7c8f ]
smatch warning was reported as below ->
smatch warnings:
drivers/irqchip/irq-nvic.c:131 nvic_of_init()
warn: 'nvic_base' not released on lines: 97.
Release nvic_base upon failure.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220218163303.33344-1-jrdr.linux@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/irqchip/irq-nvic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
index 21cb31ff2bbf..e903c44edb64 100644
--- a/drivers/irqchip/irq-nvic.c
+++ b/drivers/irqchip/irq-nvic.c
@@ -94,6 +94,7 @@ static int __init nvic_of_init(struct device_node *node,
if (!nvic_irq_domain) {
pr_warn("Failed to allocate irq domain\n");
+ iounmap(nvic_base);
return -ENOMEM;
}
@@ -103,6 +104,7 @@ static int __init nvic_of_init(struct device_node *node,
if (ret) {
pr_warn("Failed to allocate irq chips\n");
irq_domain_remove(nvic_irq_domain);
+ iounmap(nvic_base);
return ret;
}
--
2.34.1
next prev parent reply other threads:[~2022-03-28 11:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 11:22 [PATCH AUTOSEL 5.10 01/21] LSM: general protection fault in legacy_parse_param Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 02/21] regulator: rpi-panel: Handle I2C errors/timing to the Atmel Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 03/21] gcc-plugins/stackleak: Exactly match strings instead of prefixes Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 04/21] pinctrl: npcm: Fix broken references to chip->parent_device Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 05/21] block, bfq: don't move oom_bfqq Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 06/21] selinux: use correct type for context length Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 07/21] selinux: allow FIOCLEX and FIONCLEX with policy capability Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 08/21] loop: use sysfs_emit() in the sysfs xxx show() Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 09/21] Fix incorrect type in assignment of ipv6 port for audit Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 10/21] irqchip/qcom-pdc: Fix broken locking Sasha Levin
2022-03-28 11:22 ` Sasha Levin [this message]
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 12/21] fs/binfmt_elf: Fix AT_PHDR for unusual ELF files Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 13/21] bfq: fix use-after-free in bfq_dispatch_request Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 14/21] ACPICA: Avoid walking the ACPI Namespace if it is not there Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 15/21] lib/raid6/test/Makefile: Use $(pound) instead of \# for Make 4.3 Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 16/21] Revert "Revert "block, bfq: honor already-setup queue merges"" Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 17/21] ACPI/APEI: Limit printable size of BERT table data Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 18/21] PM: core: keep irq flags in device_pm_check_callbacks() Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 19/21] parisc: Fix handling off probe non-access faults Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 20/21] nvme-tcp: lockdep: annotate in-kernel sockets Sasha Levin
2022-03-28 11:22 ` [PATCH AUTOSEL 5.10 21/21] spi: tegra20: Use of_device_get_match_data() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328112254.1556286-11-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maz@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox