From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C711C433F5 for ; Mon, 28 Mar 2022 11:28:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239170AbiC1La0 (ORCPT ); Mon, 28 Mar 2022 07:30:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241168AbiC1L3H (ORCPT ); Mon, 28 Mar 2022 07:29:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2AEB554A9; Mon, 28 Mar 2022 04:24:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C7445611B7; Mon, 28 Mar 2022 11:24:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ADB0C340F3; Mon, 28 Mar 2022 11:23:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648466640; bh=HAjsokNLpm1BGeHXA8hl2TeS4FY5QiuvnC9KI1mxvmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KXenh1764i9pDYi+egaVWbefepaux1fsNbmymGIWXLOTgBFVlbRH8DrSZ3kVgwtiG bQbLbFoB8MBJ5AmBH0fuwPWHq6u6RPShbFGdJzdrg4Yu8NHUDDvP5DXz1UnmNwU5e1 EPw2SmNl+3qrO0m5yZQyqwtaRXSIlKHY4QbFy4JnkyxIDKzPAporBhqL754MgD3CUx kA4X0oweO6wA7iEpcx8/M718TDrwliORAvQJUypy6INT7BL1m4TXU0VzketHgITi+u /mK6sD27N6BVrXg0rV3e5C9IG+6cz6tn2d6ZHG85S6wcxFGZRXdkIjDw+BGhXicgpH 0VH3PKcT8myJQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Marc Zyngier , Maulik Shah , Sasha Levin , agross@kernel.org, bjorn.andersson@linaro.org, tglx@linutronix.de, linux-arm-msm@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 08/16] irqchip/qcom-pdc: Fix broken locking Date: Mon, 28 Mar 2022 07:23:37 -0400 Message-Id: <20220328112345.1556601-8-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220328112345.1556601-1-sashal@kernel.org> References: <20220328112345.1556601-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marc Zyngier [ Upstream commit a6aca2f460e203781dc41391913cc5b54f4bc0ce ] pdc_enable_intr() serves as a primitive to qcom_pdc_gic_{en,dis}able, and has a raw spinlock for mutual exclusion, which is uses with interruptible primitives. This means that this critical section can itself be interrupted. Should the interrupt also be a PDC interrupt, and the endpoint driver perform an irq_disable() on that interrupt, we end-up in a deadlock. Fix this by using the irqsave/irqrestore variants of the locking primitives. Signed-off-by: Marc Zyngier Reviewed-by: Maulik Shah Link: https://lore.kernel.org/r/20220224101226.88373-5-maz@kernel.org Signed-off-by: Sasha Levin --- drivers/irqchip/qcom-pdc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c index faa7d61b9d6c..239a889df608 100644 --- a/drivers/irqchip/qcom-pdc.c +++ b/drivers/irqchip/qcom-pdc.c @@ -50,17 +50,18 @@ static u32 pdc_reg_read(int reg, u32 i) static void pdc_enable_intr(struct irq_data *d, bool on) { int pin_out = d->hwirq; + unsigned long flags; u32 index, mask; u32 enable; index = pin_out / 32; mask = pin_out % 32; - raw_spin_lock(&pdc_lock); + raw_spin_lock_irqsave(&pdc_lock, flags); enable = pdc_reg_read(IRQ_ENABLE_BANK, index); enable = on ? ENABLE_INTR(enable, mask) : CLEAR_INTR(enable, mask); pdc_reg_write(IRQ_ENABLE_BANK, index, enable); - raw_spin_unlock(&pdc_lock); + raw_spin_unlock_irqrestore(&pdc_lock, flags); } static void qcom_pdc_gic_mask(struct irq_data *d) -- 2.34.1