From: Won Chung <wonchung@google.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Benson Leung <bleung@google.com>,
Prashant Malani <pmalani@google.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Won Chung <wonchung@google.com>
Subject: [PATCH v2] sound/hda: Add NULL check to component match callback function
Date: Wed, 30 Mar 2022 20:55:43 +0000 [thread overview]
Message-ID: <20220330205543.2064615-1-wonchung@google.com> (raw)
Component match callback function needs to check if expected data is
passed to it. Without this check, it can cause a NULL pointer
dereference when another driver registers a component before i915
drivers have their component master fully bind.
Fixes: 7b882fe3e3e8b ("ALSA: hda - handle multiple i915 device instances")
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Won Chung <wonchung@google.com>
---
- Add "Fixes" tag
- Send to stable@vger.kernel.org
sound/hda/hdac_i915.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c
index efe810af28c5..958b0975fa40 100644
--- a/sound/hda/hdac_i915.c
+++ b/sound/hda/hdac_i915.c
@@ -102,13 +102,13 @@ static int i915_component_master_match(struct device *dev, int subcomponent,
struct pci_dev *hdac_pci, *i915_pci;
struct hdac_bus *bus = data;
- if (!dev_is_pci(dev))
+ if (!dev_is_pci(dev) || !bus)
return 0;
hdac_pci = to_pci_dev(bus->dev);
i915_pci = to_pci_dev(dev);
- if (!strcmp(dev->driver->name, "i915") &&
+ if (dev->driver && !strcmp(dev->driver->name, "i915") &&
subcomponent == I915_COMPONENT_AUDIO &&
connectivity_check(i915_pci, hdac_pci))
return 1;
--
2.35.1.1021.g381101b075-goog
next reply other threads:[~2022-03-30 20:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 20:55 Won Chung [this message]
2022-03-30 21:15 ` [PATCH v2] sound/hda: Add NULL check to component match callback function Won Chung
-- strict thread matches above, loose matches on Subject: below --
2022-03-30 21:19 Won Chung
2022-03-31 7:27 ` Takashi Iwai
2022-03-31 8:38 ` Won Chung
2022-03-31 9:12 ` Takashi Iwai
2022-03-31 9:25 ` Heikki Krogerus
2022-03-31 9:28 ` Takashi Iwai
2022-03-31 9:34 ` Heikki Krogerus
2022-03-31 9:45 ` Takashi Iwai
2022-03-31 13:29 ` Takashi Iwai
2022-03-31 14:19 ` Takashi Iwai
2022-03-31 15:33 ` Benson Leung
2022-03-31 15:37 ` Takashi Iwai
2022-03-31 16:10 ` Mika Westerberg
2022-03-31 16:38 ` Greg KH
2022-03-31 16:58 ` Won Chung
2022-03-31 17:18 ` Greg KH
2022-03-31 17:33 ` Benson Leung
2022-03-31 17:46 ` Greg KH
2022-04-01 7:02 ` Heikki Krogerus
2022-03-31 11:39 ` Greg KH
2022-03-31 12:52 ` Heikki Krogerus
2022-03-31 12:56 ` Greg KH
2022-03-31 13:15 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330205543.2064615-1-wonchung@google.com \
--to=wonchung@google.com \
--cc=bleung@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=perex@perex.cz \
--cc=pmalani@google.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox