From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Zheng Yongjun <zhengyongjun3@huawei.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Sasha Levin <sashal@kernel.org>,
davem@davemloft.net, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, nicolas.toromanoff@foss.st.com,
marex@denx.de, linux-crypto@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH AUTOSEL 5.10 11/25] crypto: stm32 - fix reference leak in stm32_crc_remove
Date: Wed, 6 Apr 2022 21:13:59 -0400 [thread overview]
Message-ID: <20220407011413.114662-11-sashal@kernel.org> (raw)
In-Reply-To: <20220407011413.114662-1-sashal@kernel.org>
From: Zheng Yongjun <zhengyongjun3@huawei.com>
[ Upstream commit e9a36feecee0ee5845f2e0656f50f9942dd0bed3 ]
pm_runtime_get_sync() will increment pm usage counter even it
failed. Forgetting to call pm_runtime_put_noidle will result
in reference leak in stm32_crc_remove, so we should fix it.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/crypto/stm32/stm32-crc32.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/stm32/stm32-crc32.c b/drivers/crypto/stm32/stm32-crc32.c
index be1bf39a317d..90a920e7f664 100644
--- a/drivers/crypto/stm32/stm32-crc32.c
+++ b/drivers/crypto/stm32/stm32-crc32.c
@@ -384,8 +384,10 @@ static int stm32_crc_remove(struct platform_device *pdev)
struct stm32_crc *crc = platform_get_drvdata(pdev);
int ret = pm_runtime_get_sync(crc->dev);
- if (ret < 0)
+ if (ret < 0) {
+ pm_runtime_put_noidle(crc->dev);
return ret;
+ }
spin_lock(&crc_list.lock);
list_del(&crc->list);
--
2.35.1
next prev parent reply other threads:[~2022-04-07 1:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 1:13 [PATCH AUTOSEL 5.10 01/25] gfs2: assign rgrp glock before compute_bitstructs Sasha Levin
2022-04-07 1:13 ` [PATCH AUTOSEL 5.10 02/25] rtc: fix use-after-free on device removal Sasha Levin
2022-04-07 1:13 ` [PATCH AUTOSEL 5.10 03/25] rtc: pcf2127: fix bug when reading alarm registers Sasha Levin
2022-04-07 1:13 ` [PATCH AUTOSEL 5.10 04/25] um: Cleanup syscall_handler_t definition/cast, fix warning Sasha Levin
2022-04-07 1:13 ` [PATCH AUTOSEL 5.10 05/25] um: port_user: Improve error handling when port-helper is not found Sasha Levin
2022-04-07 1:13 ` [PATCH AUTOSEL 5.10 06/25] Input: add bounds checking to input_set_capability() Sasha Levin
2022-04-07 1:13 ` [PATCH AUTOSEL 5.10 07/25] Input: stmfts - fix reference leak in stmfts_input_open Sasha Levin
2022-04-07 1:13 ` [PATCH AUTOSEL 5.10 08/25] nvme-pci: add quirks for Samsung X5 SSDs Sasha Levin
2022-04-07 1:13 ` [PATCH AUTOSEL 5.10 09/25] gfs2: Disable page faults during lockless buffered reads Sasha Levin
2022-04-07 1:13 ` [PATCH AUTOSEL 5.10 10/25] rtc: sun6i: Fix time overflow handling Sasha Levin
2022-04-07 1:13 ` Sasha Levin [this message]
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 12/25] crypto: x86/chacha20 - Avoid spurious jumps to other functions Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 13/25] ALSA: hda/realtek: Enable headset mic on Lenovo P360 Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 14/25] s390/pci: improve zpci_dev reference counting Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 15/25] vhost_vdpa: don't setup irq offloading when irq_num < 0 Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 16/25] tools/virtio: compile with -pthread Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 17/25] nvme-multipath: fix hang when disk goes live over reconnect Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 18/25] rtc: mc146818-lib: Fix the AltCentury for AMD platforms Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 19/25] fs: fix an infinite loop in iomap_fiemap Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 20/25] MIPS: lantiq: check the return value of kzalloc() Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 21/25] drbd: remove usage of list iterator variable after loop Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 22/25] platform/chrome: cros_ec_debugfs: detach log reader wq from devm Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 23/25] ARM: 9191/1: arm/stacktrace, kasan: Silence KASAN warnings in unwind_frame() Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 24/25] nilfs2: fix lockdep warnings in page operations for btree nodes Sasha Levin
2022-04-07 1:14 ` [PATCH AUTOSEL 5.10 25/25] nilfs2: fix lockdep warnings during disk space reclamation Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407011413.114662-11-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marex@denx.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.toromanoff@foss.st.com \
--cc=stable@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox