From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C3D9C43217 for ; Tue, 19 Apr 2022 18:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356993AbiDSSZ0 (ORCPT ); Tue, 19 Apr 2022 14:25:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356992AbiDSSWd (ORCPT ); Tue, 19 Apr 2022 14:22:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1B1513DC6; Tue, 19 Apr 2022 11:14:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3F52C60DBC; Tue, 19 Apr 2022 18:14:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 945D5C385A9; Tue, 19 Apr 2022 18:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650392092; bh=kJ2xY2WZgC5zmpjwAqT8+oSDGHDnpl9nTFmzZW9q5wU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c91cNeTz/iKsQ1pv05+ZtK1unl7+3myySUYum8tYeXAf1kAhtZ7cl884OI1jJ203f Z/lN89FR0uQj4srWh69tFPTgaRpGPohqbpWdhMKcTiG8J1XwHCrY7qf12hmRlWM0E3 G3YndofG6Y80iieeCWckjZbwU542OUU0b1Jes2XOUpeHeGrNTB6l5wsRvevdXejIrQ imk0E6+/E7K4wmzYSs6ikpfXMuXQUc/MEyI2Y2025iQATJe9Lj28gJw2hn2lqB0NMJ 5/oi8Q7mA0jPbunbRsevEDUC9NTZMVXfKh6ltrm6MofRVajcL8jyslPNJ8VqXxAehO qGBKGsjGq+JbA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiapeng Chong , Abaci Robot , Hans de Goede , Sasha Levin , corentin.chary@gmail.com, markgross@kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 03/14] platform/x86: samsung-laptop: Fix an unsigned comparison which can never be negative Date: Tue, 19 Apr 2022 14:14:32 -0400 Message-Id: <20220419181444.485959-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220419181444.485959-1-sashal@kernel.org> References: <20220419181444.485959-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jiapeng Chong [ Upstream commit 0284d4d1be753f648f28b77bdfbe6a959212af5c ] Eliminate the follow smatch warnings: drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: unsigned 'value' is never less than zero. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Link: https://lore.kernel.org/r/20220322061830.105579-1-jiapeng.chong@linux.alibaba.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Sasha Levin --- drivers/platform/x86/samsung-laptop.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c index 9b6a93ff41ff..91e468fcaf7c 100644 --- a/drivers/platform/x86/samsung-laptop.c +++ b/drivers/platform/x86/samsung-laptop.c @@ -1121,8 +1121,6 @@ static void kbd_led_set(struct led_classdev *led_cdev, if (value > samsung->kbd_led.max_brightness) value = samsung->kbd_led.max_brightness; - else if (value < 0) - value = 0; samsung->kbd_led_wk = value; queue_work(samsung->led_workqueue, &samsung->kbd_led_work); -- 2.35.1