From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04938C433EF for ; Tue, 19 Apr 2022 18:22:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356906AbiDSSYp (ORCPT ); Tue, 19 Apr 2022 14:24:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357327AbiDSSXJ (ORCPT ); Tue, 19 Apr 2022 14:23:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6346A43496; Tue, 19 Apr 2022 11:15:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1F00FB818E0; Tue, 19 Apr 2022 18:15:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAC96C385A7; Tue, 19 Apr 2022 18:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650392147; bh=j7amTvci1rK5poKpvcIYr4L3A0uwvlLReL8CwaJdS20=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t7lrh+9bIHghDFvN98RiScWItVMMYxqVP+u+5qvp5QOc7qbp8KwtL0YaJG5YJgNCz J/uo3h2wUdvSTUCZr57jusd5dqDLWmHW2PXM3QaMgNT1EF6a1a1z2OKTiVFr6cwOPC EGmE5tFMwySgtUokbWG5njmGzloks1y5OAmg4bs407yfMvZnRFwOGSvH+YKeyKNLDF aZ/9Tuy4nb+rmJNOBoB3v1BdPVz1zpowhP6Q9XZXPRwGHKXjdTjHXAkGXp13mjucKV /Hj9wAeocvCxD+Qk2XvHbMe7omT9j4rflRBirsXHzbKlJqN5Vfg5Yk7if1COwhVrI5 9y91S008MVsXg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lv Ruyi , Zeal Robot , "David S . Miller" , Sasha Levin , madalin.bucur@nxp.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 09/12] dpaa_eth: Fix missing of_node_put in dpaa_get_ts_info() Date: Tue, 19 Apr 2022 14:15:22 -0400 Message-Id: <20220419181525.486166-9-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220419181525.486166-1-sashal@kernel.org> References: <20220419181525.486166-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Lv Ruyi [ Upstream commit 1a7eb80d170c28be2928433702256fe2a0bd1e0f ] Both of of_get_parent() and of_parse_phandle() return node pointer with refcount incremented, use of_node_put() on it to decrease refcount when done. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c index 3184c8f7cdd0..6e69bcdf9c40 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c @@ -530,11 +530,15 @@ static int dpaa_get_ts_info(struct net_device *net_dev, info->phc_index = -1; fman_node = of_get_parent(mac_node); - if (fman_node) + if (fman_node) { ptp_node = of_parse_phandle(fman_node, "ptimer-handle", 0); + of_node_put(fman_node); + } - if (ptp_node) + if (ptp_node) { ptp_dev = of_find_device_by_node(ptp_node); + of_node_put(ptp_node); + } if (ptp_dev) ptp = platform_get_drvdata(ptp_dev); -- 2.35.1