From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D98C4332F for ; Tue, 26 Apr 2022 19:03:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353915AbiDZTG4 (ORCPT ); Tue, 26 Apr 2022 15:06:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353906AbiDZTGX (ORCPT ); Tue, 26 Apr 2022 15:06:23 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D0EB19B548; Tue, 26 Apr 2022 12:03:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 89DAFCE20ED; Tue, 26 Apr 2022 19:03:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE24FC385B5; Tue, 26 Apr 2022 19:03:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650999782; bh=mptsVlstBe9PgiegdjZZsGPgQatHpBsJM0+b0sy31Is=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZBw/AAlETmjUI4rf7KyPdPKYZHaDZLGPImAkBqqZSRuCmOC4cg2w4PRXOHMPNuckL C1o7xhNRK10CRwt5ateruRAbKV7eKnS723dQeiDox3IBsXDO3pPwiJuAzG+EOD4ZZO 0aS9hRja/F8r3zA8jwWPAN7LRmP4Of6IvZ/mOQDRmAj0ajtX+4tw6w2MnvOZbJ2ObE 5DYo0xzIq9ZZC5DRVj4jv3QskrjRS1kodo1B4Worgv18yGjbzBowPJUy41NE01gStp UaHvQjnkN41Z/byXeZAl0hmxxZPOLufrDGrzccrwLdmslc26DNjDNEPebU/84vF8S+ 3OU9ZyErC707Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zheyu Ma , Damien Le Moal , Sasha Levin , linux-ide@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 5/5] ata: pata_marvell: Check the 'bmdma_addr' beforing reading Date: Tue, 26 Apr 2022 15:02:56 -0400 Message-Id: <20220426190258.2351902-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220426190258.2351902-1-sashal@kernel.org> References: <20220426190258.2351902-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zheyu Ma [ Upstream commit aafa9f958342db36c17ac2a7f1b841032c96feb4 ] Before detecting the cable type on the dma bar, the driver should check whether the 'bmdma_addr' is zero, which means the adapter does not support DMA, otherwise we will get the following error: [ 5.146634] Bad IO access at port 0x1 (return inb(port)) [ 5.147206] WARNING: CPU: 2 PID: 303 at lib/iomap.c:44 ioread8+0x4a/0x60 [ 5.150856] RIP: 0010:ioread8+0x4a/0x60 [ 5.160238] Call Trace: [ 5.160470] [ 5.160674] marvell_cable_detect+0x6e/0xc0 [pata_marvell] [ 5.161728] ata_eh_recover+0x3520/0x6cc0 [ 5.168075] ata_do_eh+0x49/0x3c0 Signed-off-by: Zheyu Ma Signed-off-by: Damien Le Moal Signed-off-by: Sasha Levin --- drivers/ata/pata_marvell.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c index ff468a6fd8dd..677f582cf3d6 100644 --- a/drivers/ata/pata_marvell.c +++ b/drivers/ata/pata_marvell.c @@ -82,6 +82,8 @@ static int marvell_cable_detect(struct ata_port *ap) switch(ap->port_no) { case 0: + if (!ap->ioaddr.bmdma_addr) + return ATA_CBL_PATA_UNK; if (ioread8(ap->ioaddr.bmdma_addr + 1) & 1) return ATA_CBL_PATA40; return ATA_CBL_PATA80; -- 2.35.1