stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kun(llfl)" <llfl@linux.alibaba.com>
To: Jiangbo Wu <jiangbo.wu@intel.com>
Cc: Xu Yu <xuyu@linux.alibaba.com>, Kun <llfl@linux.alibaba.com>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Sanjay Kumar <sanjay.k.kumar@intel.com>,
	stable@vger.kernel.org, Jon Derrick <jonathan.derrick@intel.com>
Subject: [PATCH 06/19] iommu/vt-d: Fix clearing real DMA device's scalable-mode context entries
Date: Fri,  6 May 2022 20:00:44 +0800	[thread overview]
Message-ID: <20220506120057.77320-6-llfl@linux.alibaba.com> (raw)
In-Reply-To: <20220506120057.77320-1-llfl@linux.alibaba.com>

From: Lu Baolu <baolu.lu@linux.intel.com>

ANBZ: #1105

commit 474dd1c6506411752a9b2f2233eec11f1733a099 upstream.

The commit 2b0140c69637e ("iommu/vt-d: Use pci_real_dma_dev() for mapping")
fixes an issue of "sub-device is removed where the context entry is cleared
for all aliases". But this commit didn't consider the PASID entry and PASID
table in VT-d scalable mode. This fix increases the coverage of scalable
mode.

Suggested-by: Sanjay Kumar <sanjay.k.kumar@intel.com>
Fixes: 8038bdb855331 ("iommu/vt-d: Only clear real DMA device's context entries")
Fixes: 2b0140c69637e ("iommu/vt-d: Use pci_real_dma_dev() for mapping")
Cc: stable@vger.kernel.org # v5.6+
Cc: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Kun(llfl) <llfl@linux.alibaba.com>
---
 drivers/iommu/intel/iommu.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index 1a0027da6dad..34e498619210 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -5126,14 +5126,13 @@ static void __dmar_remove_one_dev_info(struct device_domain_info *info)
 	iommu = info->iommu;
 	domain = info->domain;
 
-	if (info->dev) {
+	if (info->dev && !dev_is_real_dma_subdevice(info->dev)) {
 		if (dev_is_pci(info->dev) && sm_supported(iommu))
 			intel_pasid_tear_down_entry(iommu, info->dev,
 					PASID_RID2PASID, false);
 
 		iommu_disable_dev_iotlb(info);
-		if (!dev_is_real_dma_subdevice(info->dev))
-			domain_context_clear(info);
+		domain_context_clear(info);
 		intel_pasid_free_table(info->dev);
 	}
 
-- 
2.32.0 (Apple Git-132)


  parent reply	other threads:[~2022-05-06 12:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220506120057.77320-1-llfl@linux.alibaba.com>
2022-05-06 12:00 ` [PATCH 05/19] iommu/vt-d: Global devTLB flush when present context entry changed Kun(llfl)
2022-05-06 14:52   ` Greg KH
     [not found]     ` <2fa72980-d94f-3257-1ea4-5ff9c77f8b59@linux.alibaba.com>
2022-05-07 11:29       ` Greg KH
2022-05-06 12:00 ` Kun(llfl) [this message]
2022-05-06 14:52   ` [PATCH 06/19] iommu/vt-d: Fix clearing real DMA device's scalable-mode context entries Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220506120057.77320-6-llfl@linux.alibaba.com \
    --to=llfl@linux.alibaba.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=jiangbo.wu@intel.com \
    --cc=jonathan.derrick@intel.com \
    --cc=sanjay.k.kumar@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=xuyu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).