From: Dan Carpenter <dan.carpenter@oracle.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH v2] nvmem: brcm_nvram: check for allocation failure
Date: Fri, 20 May 2022 09:50:24 +0300 [thread overview]
Message-ID: <20220520065023.GB23160@kadam> (raw)
In-Reply-To: <5b219857-4fe9-2406-2c6f-0511e8c33765@linaro.org>
On Thu, May 19, 2022 at 06:03:56PM +0100, Srinivas Kandagatla wrote:
>
>
> On 19/05/2022 17:56, Greg KH wrote:
> > On Tue, May 10, 2022 at 10:35:40AM +0100, Srinivas Kandagatla wrote:
> > > From: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > > Check for if the kcalloc() fails.
> > >
> > > Cc: stable@vger.kernel.org
> > > Fixes: 299dc152721f ("nvmem: brcm_nvram: parse NVRAM content into NVMEM cells")
> >
> > This isn't a commit in any tree that I can see, are you sure it is
> > correct?
> Looks like the commit is not correct,
> It should be
>
> Fixes: 6e977eaa8280 ("nvmem: brcm_nvram: parse NVRAM content into NVMEM
> cells")
>
>
> Dan, can you send this with fix to Fixes tag?
No problem. Done.
The problem is that Fixes tags will change if you use email instead of
git pulls. Or maybe someone used git and did a rebase? The point is if
you just use git everywhere and don't rebase then the hashes are
immutable.
No stress though, we figured it out.
regards,
dan carpenter
prev parent reply other threads:[~2022-05-20 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 9:35 [PATCH v2] nvmem: brcm_nvram: check for allocation failure Srinivas Kandagatla
2022-05-19 16:56 ` Greg KH
2022-05-19 17:03 ` Srinivas Kandagatla
2022-05-20 6:50 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520065023.GB23160@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox