From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9428CCA46F for ; Wed, 1 Jun 2022 14:11:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354452AbiFAOLE (ORCPT ); Wed, 1 Jun 2022 10:11:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354403AbiFAOJZ (ORCPT ); Wed, 1 Jun 2022 10:09:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19305A5035; Wed, 1 Jun 2022 07:00:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BAD43B81AEB; Wed, 1 Jun 2022 14:00:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C96DC3411D; Wed, 1 Jun 2022 14:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654092037; bh=yFAJjDuee0KkcfhDSAPMvVKX9B6AQABnodhfFK3su7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QV0i+AP3dXX/YtCh7xn+/hyEiipkIPulx8QJOeH7DAUxqps/OZ7fjI6MNSALBOAsK 4rGAzgQTwXv7Ryzn8vXPK8NbTaMX/D+ICT50LSYpCMs9BPN0N0Kt0WqgoSp9qZywuP vqTscIB6hK4ekCd+afwLn6GAvb0je1zkNvKw/2R7BPH4oBmxPvf/sItIS7cL40iJlV 7e3w3zgO9tcpe+mrslMkb4z3mB3ZD5v1WwFNm/u0UnejKeeXGuba0cvbN6tBuFxaIY AAP6Z8tW5Sliw3dFo+RF2BJwUySB5thxx52tXx1nuDUkwr7o2Xoiv9yfBtYRskYdF/ rt5vWaOLZCRgw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: OGAWA Hirofumi , qianfan , Andrew Morton , Sasha Levin Subject: [PATCH AUTOSEL 4.14 05/14] fat: add ratelimit to fat*_ent_bread() Date: Wed, 1 Jun 2022 10:00:18 -0400 Message-Id: <20220601140027.2005280-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220601140027.2005280-1-sashal@kernel.org> References: <20220601140027.2005280-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: OGAWA Hirofumi [ Upstream commit 183c3237c928109d2008c0456dff508baf692b20 ] fat*_ent_bread() can be the cause of too many report on I/O error path. So use fat_msg_ratelimit() instead. Link: https://lkml.kernel.org/r/87bkxogfeq.fsf@mail.parknet.co.jp Signed-off-by: OGAWA Hirofumi Reported-by: qianfan Tested-by: qianfan Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/fat/fatent.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c index 24ed1f4e48ae..3ef3e773da1b 100644 --- a/fs/fat/fatent.c +++ b/fs/fat/fatent.c @@ -92,7 +92,8 @@ static int fat12_ent_bread(struct super_block *sb, struct fat_entry *fatent, err_brelse: brelse(bhs[0]); err: - fat_msg(sb, KERN_ERR, "FAT read failed (blocknr %llu)", (llu)blocknr); + fat_msg_ratelimit(sb, KERN_ERR, "FAT read failed (blocknr %llu)", + (llu)blocknr); return -EIO; } @@ -105,8 +106,8 @@ static int fat_ent_bread(struct super_block *sb, struct fat_entry *fatent, fatent->fat_inode = MSDOS_SB(sb)->fat_inode; fatent->bhs[0] = sb_bread(sb, blocknr); if (!fatent->bhs[0]) { - fat_msg(sb, KERN_ERR, "FAT read failed (blocknr %llu)", - (llu)blocknr); + fat_msg_ratelimit(sb, KERN_ERR, "FAT read failed (blocknr %llu)", + (llu)blocknr); return -EIO; } fatent->nr_bhs = 1; -- 2.35.1